Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

TypeError on frontend when narrowing browser in multi column mode #11630

Closed
zunda opened this issue Aug 20, 2019 · 0 comments · Fixed by #11655
Closed

TypeError on frontend when narrowing browser in multi column mode #11630

zunda opened this issue Aug 20, 2019 · 0 comments · Fixed by #11655

Comments

@zunda
Copy link
Contributor

zunda commented Aug 20, 2019

Expected behaviour

Browser shows the single expected column after narrowing the browser window in multi column mode.

Actual behaviour

Browser shows the sad elephant. Browser console shows TypeError in components/column_header.js because document.getElementById('tabs-bar__portal') returns null.

shonbori

ThibG reported this may also happen for the ColumnBackButton component.

Steps to reproduce the problem

Enable multi column mode, navigate to HTL or LTL, than narrow the browser window.

Specifications

I noticed the problem on a server running on master at f96f45e around August 3rd, 2019. The problem is seen at least on Firefox on macOS, Firefox on Linux, and Chromium on Linux.

It turned out my proposal for a fix on #11605 is premature. I'd like to move the conversation here and seek for a better solution from experts.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant