Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update NASM and VapourSynth in windows-build.yml #866

Merged
merged 1 commit into from
Aug 16, 2024

Conversation

Uranite
Copy link
Contributor

@Uranite Uranite commented Aug 16, 2024

And remove unnecessary Python setup

And remove unnecessary Python setup
Copy link
Collaborator

@shssoichiro shssoichiro left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm, thanks!

@shssoichiro shssoichiro merged commit 6d9e660 into master-of-zen:master Aug 16, 2024
5 checks passed
@Uranite Uranite deleted the patch-2 branch August 17, 2024 13:50
@FreezyLemon
Copy link
Contributor

FreezyLemon commented Aug 18, 2024

IIRC this was necessary because the default python version on the runner was not compatible with the chosen VS version. It's likely this changed (which is why it works now), but note that this could break down the line when the github action runners are updated.

@Uranite
Copy link
Contributor Author

Uranite commented Aug 19, 2024

IIRC this was necessary because the default python version on the runner was not compatible with the chosen VS version. It's likely this changed (which is why it works now), but note that this could break down the line when the github action runners are updated.

Hmm, that cant be it, since VapourSynth is portable and you don't need python for portable vapoursynth

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants