Fix vmaf flag check with target-quality #823
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fixes issue where final vmaf was always ran if target-quality was set, this does not allow you to run vmaf without target-quality
|
👍🏽 |
master-of-zen
approved these changes
Apr 23, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes issue where vmaf plot was always ran if target-quality was set, this does not allow you to run vmaf plot without target-quality as it seems like vmaf plot was designed around target-quality at some point so --vmaf without --target-quality will do nothing. Decoupling the two seems like it will be a lot of work so I am adding this for now as it atleast closes #790 and the decoupling can happen later