Skip to content

Commit

Permalink
DP-24093: Remove "Show" and "Hide" from the Sitewide alert display (#…
Browse files Browse the repository at this point in the history
…1419)

* Remove show/hide from emergency alerts

* Changelog

* Change mayflower version

* Mayflower-artifacts

* Mayflower-artifacts

* link to MF

* link to MF develop

Co-authored-by: joeg8612 <[email protected]>
Co-authored-by: Minghua Sun <[email protected]>
  • Loading branch information
3 people authored Mar 30, 2022
1 parent 488ade9 commit 2846f90
Show file tree
Hide file tree
Showing 3 changed files with 45 additions and 8 deletions.
41 changes: 41 additions & 0 deletions changelogs/DP-24093.yml
Original file line number Diff line number Diff line change
@@ -0,0 +1,41 @@
#
# Write your changelog entry here. Every pull request must have a changelog yml file.
#
# Change types:
# #############################################################################
# You can use one of the following types:
# - Added: For new features.
# - Changed: For changes to existing functionality.
# - Deprecated: For soon-to-be removed features.
# - Removed: For removed features.
# - Fixed: For any bug fixes.
# - Security: In case of vulnerabilities.
#
# Format
# #############################################################################
# The format is crucial. Please follow the examples below. For reference, the requirements are:
# - All 3 parts are required and you must include "Type", "description" and "issue".
# - "Type" must be left aligned and followed by a colon.
# - "description" must be indented with 2 spaces followed by a colon
# - "issue" must be indented with 4 spaces followed by a colon.
# - "issue" is for the Jira ticket number only e.g. DP-1234
# - No extra spaces, indents, or blank lines are allowed.
#
# Example:
# #############################################################################
# Fixed:
# - description: Fixes scrolling on edit pages in Safari.
# issue: DP-13314
#
# You may add more than 1 description & issue for each type using the following format:
# Changed:
# - description: Automating the release branch.
# issue: DP-10166
# - description: Second change item that needs a description.
# issue: DP-19875
# - description: Third change item that needs a description along with an issue.
# issue: DP-19843
#
Removed:
- description: Removed "Show" and "Hide" from the Sitewide alert display.
issue: DP-24093
8 changes: 4 additions & 4 deletions composer.lock

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

Original file line number Diff line number Diff line change
Expand Up @@ -71,10 +71,6 @@ public function handleSiteRequest(Request $request) {

$emergencyAlerts = [
'id' => $id,
'emergencyHeader' => [
'hideText' => $this->t('Hide'),
'showText' => $this->t('Show'),
],
];

$results['emergencyAlerts'] = $emergencyAlerts;
Expand Down

0 comments on commit 2846f90

Please sign in to comment.