-
Notifications
You must be signed in to change notification settings - Fork 21
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Core/storybook integration #1271
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* Imported mayflower theme to docs For some reason storybook requires it to be impoerted there as well to available in the docs pages. Also made somee tweaks to the Mayflower sstorybook theme. * Updates to styles, markup and content for typography. Plus a few minor content changes to 'about' * Update packages/core/stories/tokens/typography/Typography.stories.mdx Co-authored-by: Minghua Sun <[email protected]> * Update packages/core/stories/tokens/typography/Typography.stories.mdx Co-authored-by: Minghua Sun <[email protected]> * Update packages/core/stories/about/Usage.stories.mdx Co-authored-by: Minghua Sun <[email protected]> * Updated vertical spacing -reverted fallbacks -reverted numbers -added class for language labels -added language labels to languages that didn't have them -indented language labels to differentiate from scripts -Corrected script names -added rtl class for labels -Moved sample to top * Apply suggestions from code review Co-authored-by: Minghua Sun <[email protected]>
Core/logo updates
* Updated content and layout * clean up and fix styles Co-authored-by: Minghua Sun <[email protected]>
* cleanup unused * remove unused package * order stories
* break up env var * add script * export update core version func * fix export * test * update func * update func * remove passing in global var and fix the func (checkout this commit to test the scripts) * remove test comments * apply review suggestions * fix error * Update scripts/update-version.js Co-authored-by: Steven Murray <[email protected]> * Revert "Update scripts/update-version.js" This reverts commit bd720a8. * Revert "apply review suggestions" This reverts commit c55cec3. Co-authored-by: Steven Murray <[email protected]>
* move narrow template theme styles * add build assets rush command * wip * add place holder * add reverse template and JS note * fix seal url in template * add doc * remove toolbar in story * fix links * add link to template doc from usage doc * add code template * Update packages/core/stories/styles/index.scss * Update packages/core/stories/styles/index.scss
* Updates to the colors story * Updates to logo page content and layout * Updates to pr per Minghua -reverted hierarchical to primary, alt, highlight sections -moved down semantic colors to below theme colors -fixed typo 'palette' * Removed logo display file * tweaks and fixes * tweaks and fixes * capitalization * match variable names * tweaks and fixes for logo docs * swapped incorrectly oredered size labels * add additional background color usage info Co-authored-by: Minghua Sun <[email protected]>
* Updated the structure of links and content and the layout of Introduction * Re-ordered brand pillars to top of principles * Update packages/core/stories/principles/Accessibility.stories.mdx Co-authored-by: Minghua Sun <[email protected]> * Moved sandbox style to end * Added imports to resolve conflict * Reverted preview js * Create _place-holder.scss -to resolve conflict with core/storybook-integration * Reverted meta.json -moved this work to navigation pr * Fixed wrap of li * Implemented LinkTo * Updated the structure of links and content and the layout of Introduction * Re-ordered brand pillars to top of principles * Update packages/core/stories/principles/Accessibility.stories.mdx Co-authored-by: Minghua Sun <[email protected]> * Moved sandbox style to end * Reverted preview js * Reverted meta.json -moved this work to navigation pr * Fixed wrap of li * Implemented LinkTo * DP-20568-storybook-navigation-update (#1290) * Added navigation update * Update meta.json * Re-organize links * Deleted some test files * Updated links Co-authored-by: Minghua Sun <[email protected]> * refactor introduction menu story links to use SectionLink component * update intro * fix and reorder * remove unused styles; Co-authored-by: Minghua Sun <[email protected]>
* fix urls in examples * clean up and add version in theme title * add build core rush command
* fix urls in examples * clean up and add version in theme title * add build core rush command * add auto deploy scripts * trigger tasks * fix * add storybook cli * force update * fix storybook command * force update * remove rushx * recreate pnpm-lock.yaml * switch docker image * add path * add mayflower-react build step into core_build_storybook * fix deploy task * install aws * remove copies of node modules * use pnpx instead of npx * only sync for stable tags * reset release trigger time and add deploy core to tag job * test cleaning up old files * fix * remove copying assets static * fix * remove test code * fix
* specify mayflower theme for docs * reorganize get started doc * upate doc * Update packages/core/stories/about/Usage.stories.mdx * add cdn examples
* Updatess to buttons and headings -Normalized heading line hieights just for display here -Gave buttons the names of their types -some code-block cleanup for readability -Fixed typos -Added missing color attribute * Updated content * Updated buttons with 2 column layout * Changed h4 to inline strong * Updates to all elements pages * Update packages/core/stories/elements/Button/Button.stories.mdx Co-authored-by: Minghua Sun <[email protected]> * Removed grid markup -also removed grid override CSS -replaced hr class with style for the element agnosstic to bottom or top -replaced all hr tags with markdown (`---`) * Added withSource noe back to buttons first strory also made some minor typo fixes and added bullets * Update packages/core/stories/elements/Button/Button.stories.mdx Co-authored-by: Minghua Sun <[email protected]> * Update packages/core/stories/elements/Button/Button.stories.mdx Co-authored-by: Minghua Sun <[email protected]> * Update packages/core/stories/elements/Button/Button.stories.mdx Co-authored-by: Minghua Sun <[email protected]> * Update packages/core/stories/elements/Link/Link.stories.mdx Co-authored-by: Minghua Sun <[email protected]> * Update packages/core/stories/styles/index.scss Co-authored-by: Minghua Sun <[email protected]> * Some minor tweaks from comments * Typo fixes * Update packages/core/stories/elements/Link/Link.stories.mdx * Update packages/core/stories/elements/Link/Link.stories.mdx Co-authored-by: Minghua Sun <[email protected]>
* Edited down accessibility resources, added to Accesibility main * Added link to resources * Updated linkto * Updated resources to just out links * Edited down accessibility resources, added to Accesibility main * Added link to resources * Updated linkto * Updated resources to just out links * More updates to text -fixed broken links -added some new descriptions
* fix urls in examples * clean up and add version in theme title * add build core rush command * add auto deploy scripts * trigger tasks * fix * add storybook cli * force update * fix storybook command * force update * remove rushx * recreate pnpm-lock.yaml * switch docker image * add path * add mayflower-react build step into core_build_storybook * fix deploy task * install aws * remove copies of node modules * use pnpx instead of npx * only sync for stable tags * reset release trigger time and add deploy core to tag job * copy react linting setup * auto lint fix * wip * wip and add missing dependency * wip * wip * lint fix and missing dependency * lint fix and missing dependency * add linting to circle * fix task order * fix build * fix circle * update requires * fix shrinkwrap error * attempt to force update cache * Updates react, assets package.json to their up to date version numbers. * Bumps circleci cache key. * Sets all packages to use the same version of sass, updates mayflower-assets version for mayflower-react dev dependencies. Co-authored-by: smurrayatwork <[email protected]>
* add header * add header hamburger component * update story * fix lint
-to comment out fonts not yet supported.
This reverts commit 3335358.
The visual regression on the Mayflower React homepage on the core/storybook-integration branch was introduced by the package upgrades in #1301 |
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
replacing #1029 (merge conflicts with develop)
To standup Core storybook site locally:
rush install
rush build
rush start:core