Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Removes global package.json, updates circleci to use node cli. #1234

Merged
merged 15 commits into from
Oct 27, 2020
Merged

Removes global package.json, updates circleci to use node cli. #1234

Show file tree
Hide file tree
Changes from 12 commits
Commits
Show all changes
15 commits
Select commit Hold shift + click to select a range
5016961
Removes global package.json, updates circleci to use node cli.
smurrayatwork Oct 26, 2020
8a93a5c
Sets build to use a new cache key in circleci.
smurrayatwork Oct 26, 2020
849b28f
Adds global node dependencies for publish scripts.
smurrayatwork Oct 26, 2020
7c55f99
Updates rush configuration.
smurrayatwork Oct 26, 2020
89808b8
Points release scripts to globally installed packages.
smurrayatwork Oct 26, 2020
1f0c12c
Temporary change to circleci config to test release_branch job.
smurrayatwork Oct 26, 2020
1d70527
Temporary change to circleci config to test release_branch job.
smurrayatwork Oct 26, 2020
76af0a3
Temporary change to circleci config to test release_branch job.
smurrayatwork Oct 27, 2020
d0832b8
Temporary change to circleci config to test release_branch job.
smurrayatwork Oct 27, 2020
c53482e
Removes testing release_branch job from circleci.
smurrayatwork Oct 27, 2020
61981d8
Sets release trigger time to 10:30AM.
smurrayatwork Oct 27, 2020
e37ca9e
Updates time to 10:45 AM for release branch.
smurrayatwork Oct 27, 2020
49500da
Update .circleci/config.yml
smurrayatwork Oct 27, 2020
69b885b
Updates github_tag path to script to be the same as release_branch.
smurrayatwork Oct 27, 2020
d2c1468
Merge branch 'develop--without-package.json' of github.com:massgov/ma…
smurrayatwork Oct 27, 2020
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
20 changes: 10 additions & 10 deletions .circleci/config.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -34,11 +34,11 @@ jobs:
- restore_cache:
name: Restore pnpm-lock.yaml
keys:
- root-npm-v4-{{ checksum "common/config/rush/pnpm-lock.yaml" }}-2
- root-npm-v4-{{ checksum "common/config/rush/pnpm-lock.yaml" }}-3
- run: {name: 'Install packages', command: 'node common/scripts/install-run-rush.js install'}
- save_cache:
name: Save NPM cache
key: root-npm-v4-{{ checksum "common/config/rush/pnpm-lock.yaml" }}-2
key: root-npm-v4-{{ checksum "common/config/rush/pnpm-lock.yaml" }}-3
paths:
- common
- packages/assets/node_modules
Expand All @@ -56,7 +56,7 @@ jobs:
- restore_cache:
name: Restore NPM Cache
keys:
- root-npm-v4-{{ checksum "common/config/rush/pnpm-lock.yaml" }}-2
- root-npm-v4-{{ checksum "common/config/rush/pnpm-lock.yaml" }}-3
- run: { name: 'Build', command: 'cd packages/patternlab/styleguide && node ../../../common/scripts/install-run-rushx.js build'}
- persist_to_workspace:
root: ~/code
Expand Down Expand Up @@ -274,12 +274,12 @@ jobs:
- *no_host_check
- restore_cache:
keys:
- root-npm-v4-{{ checksum "common/config/rush/pnpm-lock.yaml" }}-2
- run: sudo npm install -g pnpm @microsoft/rush
- root-npm-v4-{{ checksum "common/config/rush/pnpm-lock.yaml" }}-3
- run: sudo npm install -g [email protected] @octokit/rest [email protected] [email protected] [email protected]
# Identify the committer i.e. CircleCI deployment bot
- run: git config --global user.email "[email protected]"
- run: git config --global user.name "CircleCI Deployment Bot"
- run: node common/scripts/install-run-rushx.js release-branch
- run: export NODE_PATH=$(npm root --quiet -g) && node scripts/release-branch.js

github_tag:
<<: *patternlab_defaults
Expand All @@ -288,12 +288,12 @@ jobs:
- *no_host_check
- restore_cache:
keys:
- root-npm-v4-{{ checksum "common/config/rush/pnpm-lock.yaml" }}-2
- run: sudo npm install -g pnpm @microsoft/rush
- root-npm-v4-{{ checksum "common/config/rush/pnpm-lock.yaml" }}-3
- run: sudo npm install -g [email protected] @octokit/rest [email protected] [email protected] [email protected]
# Identify the committer i.e. CircleCI deployment bot
- run: git config --global user.email "[email protected]"
- run: git config --global user.name "CircleCI Deployment Bot"
- run: node common/scripts/install-run-rushx.js release-tag
- run: export NODE_PATH=$(npm root --quiet -g) && node ./scripts/release-tag.js
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
- run: export NODE_PATH=$(npm root --quiet -g) && node ./scripts/release-tag.js
- run: export NODE_PATH=$(npm root --quiet -g) && node ./scripts/release-tag.js

I guess this is the same as scripts/release-tag.js just want to make sure it works



assets_build:
Expand Down Expand Up @@ -410,7 +410,7 @@ workflows:
requires: [build]
triggers:
- schedule:
cron: "10 20 * * 1"
cron: "45 10 * * 2"
smurrayatwork marked this conversation as resolved.
Show resolved Hide resolved
filters:
branches:
only:
Expand Down
Loading