Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

DP-20241 Remove space above the sticky table header #1226

Merged
merged 4 commits into from
Oct 23, 2020

Conversation

ygannett
Copy link
Contributor

Any PRs being created needs a changelog.txt file before being merged into dev. See: Change Log Instructions

Description

Remove the space between the window top or the sticky TOC and the sticky table header.

Related Issue / Ticket

Steps to Test

  1. Go to the following pages with the responsive tables:
  1. Changing the page width, scroll up and down the tables.

  2. Find the sticky table header is positioned right below the top edge of the page window or the sticky TOC.

no-toc

toc

Screenshots

Use something like licecap to capture gifs to demonstrate behaviors.

Additional Notes:

Anything else to add?

Impacted Areas in Application

@todo

Today I learned...

@ygannett ygannett changed the title Patternlab/dp 20241 sticky table header DP-20241 Remove space above the sticky table header Oct 23, 2020
@tom-fleming
Copy link
Contributor

LGTM!

@tom-fleming tom-fleming merged commit 8771258 into develop Oct 23, 2020
@tom-fleming tom-fleming deleted the patternlab/DP-20241_sticky-table-header branch October 23, 2020 20:53
This was referenced Oct 27, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants