Core/storybook setup #1209
Closed
Core/storybook setup #1209
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* swap out richtext to be a wrapper component * remove press teaser * add changelog * allow render raw html as children * add story and documentation * update richtext screenshots * address comments * add knob to conditionally pass children * move knob out of props * conditional knob * address feedback
React/deprecate press teaser
* add changelogs * remove General Teaser * refactor teaser listing * wip remove general teaser * add genteaser classnames to listing styles * add genteaser classnames to listing styles * add back listing items * remove unnecessary contained prop * change prop to coumns * create story to show more option * convert to use button with icon * cleanup * add changelog * add documentation * add new screenshots * cleanup and convert to functional component * Update react/src/components/organisms/TeaserListing/index.js Co-authored-by: Steven Murray <[email protected]> * remove teaser * add to changelog * fix classname Co-authored-by: Steven Murray <[email protected]>
* deprecate and remove org selector * remove pressfilters * fix using input text fuzzy in typeAheadDropdown * prevent onSuggestionClick to trigger without a match * switch out input text typeahead in filterbox * remove input text typeahead * Update react/src/components/forms/InputTextFuzzy/index.js Co-authored-by: Steven Murray <[email protected]> * Update react/src/components/forms/TypeAheadDropdown/index.js Co-authored-by: Steven Murray <[email protected]> Co-authored-by: Steven Murray <[email protected]>
* DP-18263: Adds new assets package. (#1037) * DP-18263: Adds new assets package. * DP-18263: Removes stylelint ignore for dist directory. * DP-18263: Updates package name. * DP-18263: Updates circleci scripts for assets. * DP-18263: Fixes stylelint bug. * DP-18263: Updates lockfile to reflect package name change, fixes test script. * DP-18263: Moving static assets to static directory. (#1042) * DP-18263: Assets integration Branch: package version bump. (#1046) * DP-18263: Bumping mayflower-assets version. * Update assets/package.json Co-authored-by: Minghua Sun <[email protected]> Co-authored-by: Minghua Sun <[email protected]> * Assets integration: Remove Bourbon requirement from assets package. (#1051) * DP-18263: Removes the dependency on bourbon. * Updates README, version bump. * Assets Integration Branch: React Support with Mayflower Assets Package (#1047) * DP-18263: Adds support for assets package with react. * DP-18263: Updates react package to use latest mayflower-assets package, removes debugging in storybook config. * Update react/.storybook/main.js * DP-18263: Adds .env file for react. * DP-18263: Fixes bugs related to fonts, layouts. Removes bourbon and bourbon neat dependencies. * DP-18263: Fixes stylelint errors for mayflower-assets. * DP-18263: Updates mayflower-assets package. * DP-18263: Fixes visual regression on HeaderSearch component. * Assets Integration: Patternlab (#1052) * DP-18263: Adds support for mayflower-assets package to patternlab. * DP-18263: Fixes bug caused by not waiting for files to copy before processing them for building patternlab. * DP-18263: Removes bourbon and bourbon neat from patternlab. * DP-18740: Integrates React/Storybook with Assets Package (#1064) * 18740: Integrates react package with new assets package. * DP-18740: Removes build css / watch css steps. * DP-18740: Updates files to be symlink. * DP-18740: Removes babel config from nwb, combines rules for storybook babel processing. * DP-18740: Removes css, style, sass loaders in package. * DP-18740: Updates react_test job to copy docs directory into image. * DP-18740: Fixes bug with backstop custom script failing to find symlink. * Assets integration: Remove style imports from react components. (#1073) * Adds component styles to styles directory. * Removes direct importing of styles in react components. * Updated gatsby site to support new mayflower-react. * Removes react style files from component directories. * Adds back missing ContactGroup import. * Adds missing styles for form component. * WIP. * Updated react components to document required styles. * Switches build to use gulp instead of NWB. * Removes NWB, react-scripts/CRA. * Cleans up npm scripts. * Updating mayflower-react version to 10, fixes bug with gatsby site related to package version. * Fixes eslint bug caused by babel-eslint plugins. * Removing babel-eslint to fix broken builds. * Reverting update of babel-eslint to fix bugs. * Fixes gatsby site to handle new dist/ directory from react. * Adds missing mayflower-react path to sass, adds auto eslint fixes. * Adds changelog file, updates gatsby site layout styles to remove duplicates. * Updated changelog text. * Cleans up code in storybook main file. * format changelog * format changelog Co-authored-by: Minghua Sun <[email protected]> * Fixes remaining lint errors. (#1083) * Fixes bad pathing from merge conflicts. * Fixes regression on DecorativeLink. * Adding gulpfile to eslint ignore list. * Assets integration update backstop final (#1087) * Adds updated react backstop reference images. * approve patternlab screenshots * Removing files to fix conflicts with merge. * Puts back conflicitng files using assets-integration-branch as source. Co-authored-by: Minghua Sun <[email protected]> * Assets integration: Upgrades React, Patternlab, Gatsby to node 12. (#1085) * Upgrades node to v12 for react, gatsby site. * Updates node version to 12 for react circleci test. * Updates patternlab to node v12. * Assets integration: Fix React ES6 Exports (#1098) * Fixes ES Module exports to add file extensions. * WIP fix for react exports. * Revert "WIP fix for react exports." This reverts commit 57c0b64. * fix site missing styles (#1100) * Removes package exports and switches main to commonjs version. (#1101) * update mayflower-assets * Updating react circleci cache. * approve screenshots vertical spacing due to clearfix * approve react backstop screenshots * publish mayflower-react 10.0.0-alpha Co-authored-by: Minghua Sun <[email protected]>
* [assets] font weights as variables (#1054) * switch to use variables * revert paths * fix * add changelog * fix var * add lightest var * add lightest var * DP-18543 Update jquery (#1048) * Update jquery from 3.4.0 to 3.5.1 * Add changelog for DP-18543 Co-authored-by: Dan Stafford <[email protected]> * Hotfix/fix changelog (#1060) * fix release blockers * advance cron time * Changelog update and remove old changelog files * DP-18704 Solve screen flicker issue observed on Mass.gov error pages (#1065) * add the flikering issue fix * add changelog for DP-18704 * prevent the fix to be overridden * Changelog update and remove old changelog files * add fonts for vietnamese (#1068) * add fonts for vietnamese * changelog * Changelog update and remove old changelog files * Update some node package dependencies (#1069) Co-authored-by: Dan Stafford <[email protected]> * remove param from font import statement * add changelog * add missing changelog * cleanup font-family setting overrides * Revert "cleanup font-family setting overrides" This reverts commit 811eb1a. * Master (#1079) * remove param from font import statement * add changelog * add missing changelog * cleanup font-family setting overrides * Revert "cleanup font-family setting overrides" This reverts commit 811eb1a. * DP-15628 Expand a hot spot of TOC link to its parent container (#1070) * add data attribute to identify target link parent containers * add expandClickable.js * add 'data-link' to .ma__sticky-toc__link * set up toc-hierarchy and download-link with clickable.js * add visual cue at hover for the toc item link container * add comment * fix typo * test edit * remove test edit * set up toc link parent container clickable * sticky nav title fix test edit 1 * put back the missing empty line * remove test code * add test code * test edit * fix the toc title overwrapping on toc links in the flyout * add comment * expand clickable area in mobile flyout sticky toc * make the icon clickable in mobile toc * set visual indicator for link at hover on parent container of a link in toc * add changelog for DP-15628 * fix lint error * clean up comments * clean up comments * backstop error fix * fix lint error * adding a feature to update .ma__sticky-toc__current-section content with clicking .ma__sticky-toc__link and icon, fix the link feature with clicking icon * remove side margins from toc item container to make entire container clickable * put TOC item link icon behind the item container * remove test comments * hover style adjustment for child li of .ma__toc--hierarchy__accordion-content * DP-18940 Key message background image (#1082) * Replace style tags in key-message template with inline * Add changelog for DP-18940 * Fix scss for stylelint Co-authored-by: Dan Stafford <[email protected]> * Use node for HelperText message property (#1080) * Use node for HelperText message property * Add changelog entry for helpertext_proptype * Update changelogs/helpertext_proptype.yml Co-authored-by: Minghua Sun <[email protected]> * DP-17612 Fix org search styles for Firefox browser (#1088) * Bump up z-index for open search form * Add changelog for DP-17612 Co-authored-by: Dan Stafford <[email protected]> * update changelog for release 9.52.0 * Apply suggestions from code review * DP-19085 google map (#1089) * modify google-map.twig to print googleMap.link.info. * modify googleMap.link.info value to be a location name * modify googleMap.link.info value to be a location name * add condition to remove aria-hidden and role attributes when it's static. * add changelog for DP-19085 * Update npm packages (#1093) Co-authored-by: Dan Stafford <[email protected]> * DP-17404 relationship indicator change2 (#938) * relationship indicator changes from DP-17138 * change the label for the secondary set of the relationship indicator * adjust the width of each set and spacing * add changelog for DP-17150 * add pr# to the changelog * update the secondary label of the relationship indicator * update backstop reference screenshots * remove unrelated changes * correcct markup of relationshipIndicators.secondary button wrappter * fix keyboard trap with the expanded more button * fix the relationship indicator content * updating reference screenshots * add 'go to next item' commands for screen readers * merge wrapped-link into relationship-indicators * remove the focus order feature to replace it with CSS * merge wrapped-link into the template and adjust the loop to render the button as the second item. * set the flex box order to the button for logical focus order when the list is expanded. * move the table of content overlay section to below the relationship indicator in binder internal page. * test edit * match the markup with Drupal * test edit * spacing test edit * remove test code * match spacing with prod version * put back missing mobileNav.js * add changelog for DP-17404 * remove padding top from breadkpoint 911px min * add PR number to changelog * update backstop reference screenshots * update reference screenshots * adjust spacing and clean up spacing styles * adjust specificity in css * decrease bottom margin of terms and button * test edit * adjustment for drupal * update json files * Updating reference screenshots * adjust bottom margins * add condition to check if data exists. * fix typo * correct tag for label * replace taxonomy terms output format with relationship indicator * modified display conditions * comment out existing taxonomyTerms output * adjust a display condition of .ma__page-header__tags content * Update backstop reference screenshots * adjust label bottom margin * Updating reference screenshots * content clean up with resolving merge conflicts * fix lint errors * lint fix 2 * expand focus indicator border line on .ma__relationship-indicators button * adjust the condition to add class for RI unit * remove bottom border from relationship indicator in topic page to match Drupal implementation * Updating reference screenshots * adjust padding top in the screen width less than 480px to 20px * adjust space between the relationship indicator and the banner in the width 781-910px * Update reference screenshots for mobile displays * remove unnecessary file * run release branch at 3:20 EST (#1095) * Changelog update and remove old changelog files * Fixes lint error caused by bad merge conflict fix on elements.scss. Co-authored-by: Minghua Sun <[email protected]> Co-authored-by: danstafford <[email protected]> Co-authored-by: Dan Stafford <[email protected]> Co-authored-by: CircleCI Deployment Bot <[email protected]> Co-authored-by: Yukiko Gannett <[email protected]> Co-authored-by: Rob Bayliss <[email protected]>
* [assets] font weights as variables (#1054) * switch to use variables * revert paths * fix * add changelog * fix var * add lightest var * add lightest var * DP-18543 Update jquery (#1048) * Update jquery from 3.4.0 to 3.5.1 * Add changelog for DP-18543 Co-authored-by: Dan Stafford <[email protected]> * Hotfix/fix changelog (#1060) * fix release blockers * advance cron time * Changelog update and remove old changelog files * DP-18704 Solve screen flicker issue observed on Mass.gov error pages (#1065) * add the flikering issue fix * add changelog for DP-18704 * prevent the fix to be overridden * Changelog update and remove old changelog files * add fonts for vietnamese (#1068) * add fonts for vietnamese * changelog * Changelog update and remove old changelog files * Update some node package dependencies (#1069) Co-authored-by: Dan Stafford <[email protected]> * remove param from font import statement * add changelog * add missing changelog * cleanup font-family setting overrides * Revert "cleanup font-family setting overrides" This reverts commit 811eb1a. * Master (#1079) * remove param from font import statement * add changelog * add missing changelog * cleanup font-family setting overrides * Revert "cleanup font-family setting overrides" This reverts commit 811eb1a. * DP-15628 Expand a hot spot of TOC link to its parent container (#1070) * add data attribute to identify target link parent containers * add expandClickable.js * add 'data-link' to .ma__sticky-toc__link * set up toc-hierarchy and download-link with clickable.js * add visual cue at hover for the toc item link container * add comment * fix typo * test edit * remove test edit * set up toc link parent container clickable * sticky nav title fix test edit 1 * put back the missing empty line * remove test code * add test code * test edit * fix the toc title overwrapping on toc links in the flyout * add comment * expand clickable area in mobile flyout sticky toc * make the icon clickable in mobile toc * set visual indicator for link at hover on parent container of a link in toc * add changelog for DP-15628 * fix lint error * clean up comments * clean up comments * backstop error fix * fix lint error * adding a feature to update .ma__sticky-toc__current-section content with clicking .ma__sticky-toc__link and icon, fix the link feature with clicking icon * remove side margins from toc item container to make entire container clickable * put TOC item link icon behind the item container * remove test comments * hover style adjustment for child li of .ma__toc--hierarchy__accordion-content * DP-18940 Key message background image (#1082) * Replace style tags in key-message template with inline * Add changelog for DP-18940 * Fix scss for stylelint Co-authored-by: Dan Stafford <[email protected]> * Use node for HelperText message property (#1080) * Use node for HelperText message property * Add changelog entry for helpertext_proptype * Update changelogs/helpertext_proptype.yml Co-authored-by: Minghua Sun <[email protected]> * DP-17612 Fix org search styles for Firefox browser (#1088) * Bump up z-index for open search form * Add changelog for DP-17612 Co-authored-by: Dan Stafford <[email protected]> * update changelog for release 9.52.0 * Apply suggestions from code review * DP-19085 google map (#1089) * modify google-map.twig to print googleMap.link.info. * modify googleMap.link.info value to be a location name * modify googleMap.link.info value to be a location name * add condition to remove aria-hidden and role attributes when it's static. * add changelog for DP-19085 * Update npm packages (#1093) Co-authored-by: Dan Stafford <[email protected]> * DP-17404 relationship indicator change2 (#938) * relationship indicator changes from DP-17138 * change the label for the secondary set of the relationship indicator * adjust the width of each set and spacing * add changelog for DP-17150 * add pr# to the changelog * update the secondary label of the relationship indicator * update backstop reference screenshots * remove unrelated changes * correcct markup of relationshipIndicators.secondary button wrappter * fix keyboard trap with the expanded more button * fix the relationship indicator content * updating reference screenshots * add 'go to next item' commands for screen readers * merge wrapped-link into relationship-indicators * remove the focus order feature to replace it with CSS * merge wrapped-link into the template and adjust the loop to render the button as the second item. * set the flex box order to the button for logical focus order when the list is expanded. * move the table of content overlay section to below the relationship indicator in binder internal page. * test edit * match the markup with Drupal * test edit * spacing test edit * remove test code * match spacing with prod version * put back missing mobileNav.js * add changelog for DP-17404 * remove padding top from breadkpoint 911px min * add PR number to changelog * update backstop reference screenshots * update reference screenshots * adjust spacing and clean up spacing styles * adjust specificity in css * decrease bottom margin of terms and button * test edit * adjustment for drupal * update json files * Updating reference screenshots * adjust bottom margins * add condition to check if data exists. * fix typo * correct tag for label * replace taxonomy terms output format with relationship indicator * modified display conditions * comment out existing taxonomyTerms output * adjust a display condition of .ma__page-header__tags content * Update backstop reference screenshots * adjust label bottom margin * Updating reference screenshots * content clean up with resolving merge conflicts * fix lint errors * lint fix 2 * expand focus indicator border line on .ma__relationship-indicators button * adjust the condition to add class for RI unit * remove bottom border from relationship indicator in topic page to match Drupal implementation * Updating reference screenshots * adjust padding top in the screen width less than 480px to 20px * adjust space between the relationship indicator and the banner in the width 781-910px * Update reference screenshots for mobile displays * remove unnecessary file * run release branch at 3:20 EST (#1095) * Changelog update and remove old changelog files * Fixes back merge resolution with elements.scss. * Bumps mayflower-assets version. * Updates lockfiles for new mayflower-assets version. * Fixes back merge resolution for patternlab backstop reference images. * approve screenshots Co-authored-by: Minghua Sun <[email protected]> Co-authored-by: danstafford <[email protected]> Co-authored-by: Dan Stafford <[email protected]> Co-authored-by: CircleCI Deployment Bot <[email protected]> Co-authored-by: Yukiko Gannett <[email protected]> Co-authored-by: Rob Bayliss <[email protected]>
Mayflower v10 with develop
…ow. (#1109) * Updates README for react package to reflect changes to development flow. * Update react/README.md Co-authored-by: Minghua Sun <[email protected]> * Updates readme. Co-authored-by: Minghua Sun <[email protected]>
* allow passing custom skipNav * add utilityNav and mainNav render props * fix styles * add story * change story to pass in header search * fix stylelint * add changelog * make render props new components * convert SiteLogo prop * change proptype check for SiteLogo * Update react/src/components/organisms/HeaderSlim/index.js * make skipNav proptype a component instead of function * convert prop to node type * fix * lowercase props * change mainNav component to validate the proptype works properly * approve backstop images * Update packages/assets/scss/03-organisms/_header-slim.scss Co-authored-by: Steven Murray <[email protected]> Co-authored-by: smurrayatwork <[email protected]> Co-authored-by: Steven Murray <[email protected]>
…stop reference images.
* merge conflicts * remove obsolete file * Update packages/react/src/components/organisms/FooterSlim/index.js Co-authored-by: Steven Murray <[email protected]> * Update packages/react/src/components/organisms/FooterSlim/index.js Co-authored-by: Steven Murray <[email protected]> * Update packages/react/src/components/organisms/FooterSlim/index.js Co-authored-by: Steven Murray <[email protected]> * Update packages/react/src/components/organisms/FooterSlim/FooterSlim.stories.js Co-authored-by: Steven Murray <[email protected]> * Update packages/react/src/components/organisms/FooterSlim/index.js Co-authored-by: Steven Murray <[email protected]> * update phone to be anchor link * fix default story and update siteLogo type to node * address comments * fix narrow template vrt * fix error pages vrt * approve backstop images Co-authored-by: Steven Murray <[email protected]>
* WIP. * Adds support for displaying rendered styles and html for Header, HeaderSlim, Footer, FooterSlim components. * Branch cleanup. * Code cleanup. * Fixes performance issues caused by prettier formatting displayed css. * Fixes visual regressions. * Reduces the number of scss files for preview to work. * Updates pnpm lock file. * Updates preview component to use memoization on html display, removes unused prettier plugin. Co-authored-by: Minghua Sun <[email protected]>
|
conflicts resolved on #1247 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.