DP-19877: Height of blue global nav bar is not tall enough on small screens #1179
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
joeg8612
pushed a commit
that referenced
this pull request
Oct 19, 2020
…used on home page (#1094) * Merging Hamburger nav functionality * Fixing hamburger menu search icon position * Adding MD files to describe the templates * Updating reference screenshots * Adding header mixed template * Adding header mixed template, adding covid 19 sample url * Stylelint fixes * Adding covid link to hamburger template * Adding new homepage template with mixed header * Adding changelog * Remove unused code from header mixed template * Google translate menu tiem reverted back * Google translate menu item reverted back for hamburger header * Adding missing styles * Fixing linting issues * Fixing styles for fixed header * Fixed position nav fix * Fixing hamburger menu open nav position * Fixing hamburger menu open nav position on desktop * DP-19335 Menu button fixes (#1116) * test edit * fix the dropdown visibility to keybord and screen readers maintaiing the show/hide animation effect. * fix the dropdown visibility to keybord and screen readers maintaiing the show/hide animation effect. * comment out the condition causing the keyboard trap issue with the menu button * correct aria-hidden placement for the dropdown * add jumpToSearch functioin * disable mainNavMixed.js to avoid override mainNavHamburger.js * menu button label edit * add chevron to direct link in main nav top level * correct aria-hidden for + icon container * clean up menu button label variables * adjust icons for link and button in hamburger menu * separate hamburger utility nav style from utility-nav.scss * match utility nav in hamburger menu to main nav style * add open/close behavior to util nav in hamburger menu * separate hamburger nav utlity nav style separate from utility-nav.scss * reverting merge conflict fix 1 * reverting merge conflict fix 2 * fix search access icon in page view * fix lint errors * lint error fix * fix the hidden utility content height * correct target container for utility content * adjust vertical positioning of the menu button text * move back original styles belong to utility_nav.scss * correct class in utility item * set up open/close behaviors for wide/util nav bar 'log in to' * set up open/close behaviors for narrow/hamburger menu 'log in to * fix conflict between 'log in to' buttons * uncomment test style * set focus between menu button, hamburger menu container, jump to search button and search input * test edit * fix syntax error * merge hamburger and mix template and scss to minimize duplicate. * clean up duplicate * merge mainNavMixed.js to mainNavHamburger.js * fix width for log in to content * fix lint errors * lint error fix * fix positioning of the hamburger menu container * smooth open/close behavior of log in to content in wide version * adjust open/close behavior of log in to content in wide version * remove invalid attribute * remove duplicate markup * style log in to content in hamburger nav * fix error * fix errors * fix error * test edit * fix some lint errors in the existing code * remove test style * resolve conflicts between utilNav.js and mainNavHamburger.js * remove duplicate markup * fix conflicts between 2 utlity content displays * set container size for utility container in hamburger menu on load * hide utility nav content when sub menu in main nav is open * remove unnecessary aria-label from hamburger main nav * hide hamburger menu at resizing window in mix over 841 * Hide hamburger menu when window size is resized to over 840 while hamburger menu is open. * adjustment for Drupal output * test edit * add changelog for DP-17154 * remove box-shadow from utility nav item in hamburger menu * setting up to close sub mneu as opening the utility nav content * set up focus on the search box in the hamburger menu by clicking the search icon on the utility nav bar * clean up unnecessary tabindex and aria-label * fix typo * setting up closure with esc key * adjust focsus issue as menu open/close * fix tabindex at closing menu button * update menu button label in screen size smaller than 620px * set the menu button to line up with the state seal on the left regardless of the screen width. * add changelog for Dp-19335 * fix lint error * Updating reference screenshots * remove deplicated line * clean up comments * DP-17154 header change with new global nav (#1099) * test edit * fix the dropdown visibility to keybord and screen readers maintaiing the show/hide animation effect. * fix the dropdown visibility to keybord and screen readers maintaiing the show/hide animation effect. * comment out the condition causing the keyboard trap issue with the menu button * correct aria-hidden placement for the dropdown * add jumpToSearch functioin * disable mainNavMixed.js to avoid override mainNavHamburger.js * menu button label edit * add chevron to direct link in main nav top level * correct aria-hidden for + icon container * clean up menu button label variables * adjust icons for link and button in hamburger menu * separate hamburger utility nav style from utility-nav.scss * match utility nav in hamburger menu to main nav style * add open/close behavior to util nav in hamburger menu * separate hamburger nav utlity nav style separate from utility-nav.scss * reverting merge conflict fix 1 * reverting merge conflict fix 2 * fix search access icon in page view * fix lint errors * lint error fix * fix the hidden utility content height * correct target container for utility content * adjust vertical positioning of the menu button text * move back original styles belong to utility_nav.scss * correct class in utility item * set up open/close behaviors for wide/util nav bar 'log in to' * set up open/close behaviors for narrow/hamburger menu 'log in to * fix conflict between 'log in to' buttons * uncomment test style * set focus between menu button, hamburger menu container, jump to search button and search input * test edit * fix syntax error * merge hamburger and mix template and scss to minimize duplicate. * clean up duplicate * merge mainNavMixed.js to mainNavHamburger.js * fix width for log in to content * fix lint errors * lint error fix * fix positioning of the hamburger menu container * smooth open/close behavior of log in to content in wide version * adjust open/close behavior of log in to content in wide version * remove invalid attribute * remove duplicate markup * style log in to content in hamburger nav * fix error * fix errors * fix error * test edit * fix some lint errors in the existing code * remove test style * resolve conflicts between utilNav.js and mainNavHamburger.js * remove duplicate markup * fix conflicts between 2 utlity content displays * set container size for utility container in hamburger menu on load * hide utility nav content when sub menu in main nav is open * remove unnecessary aria-label from hamburger main nav * hide hamburger menu at resizing window in mix over 841 * Hide hamburger menu when window size is resized to over 840 while hamburger menu is open. * adjustment for Drupal output * test edit * add changelog for DP-17154 * remove box-shadow from utility nav item in hamburger menu * setting up to close sub mneu as opening the utility nav content * set up focus on the search box in the hamburger menu by clicking the search icon on the utility nav bar * clean up unnecessary tabindex and aria-label * fix typo * setting up closure with esc key * adjust focsus issue as menu open/close * fix tabindex at closing menu button * fix lint error * Updating reference screenshots * clean up comments * remove unused variable * remove backstop reference * copy screenshots from DP-17200 * add missing reference for backstop * add missing reference for backstop 2 * adjust the header bar padding to meet DP-17200 * DP-19330 Expand the menu button width with "close" label (#1119) * test edit * fix the dropdown visibility to keybord and screen readers maintaiing the show/hide animation effect. * fix the dropdown visibility to keybord and screen readers maintaiing the show/hide animation effect. * comment out the condition causing the keyboard trap issue with the menu button * correct aria-hidden placement for the dropdown * add jumpToSearch functioin * disable mainNavMixed.js to avoid override mainNavHamburger.js * menu button label edit * add chevron to direct link in main nav top level * correct aria-hidden for + icon container * clean up menu button label variables * adjust icons for link and button in hamburger menu * separate hamburger utility nav style from utility-nav.scss * match utility nav in hamburger menu to main nav style * add open/close behavior to util nav in hamburger menu * separate hamburger nav utlity nav style separate from utility-nav.scss * reverting merge conflict fix 1 * reverting merge conflict fix 2 * fix search access icon in page view * fix lint errors * lint error fix * fix the hidden utility content height * correct target container for utility content * adjust vertical positioning of the menu button text * move back original styles belong to utility_nav.scss * correct class in utility item * set up open/close behaviors for wide/util nav bar 'log in to' * set up open/close behaviors for narrow/hamburger menu 'log in to * fix conflict between 'log in to' buttons * uncomment test style * set focus between menu button, hamburger menu container, jump to search button and search input * test edit * fix syntax error * merge hamburger and mix template and scss to minimize duplicate. * clean up duplicate * merge mainNavMixed.js to mainNavHamburger.js * fix width for log in to content * fix lint errors * lint error fix * fix positioning of the hamburger menu container * smooth open/close behavior of log in to content in wide version * adjust open/close behavior of log in to content in wide version * remove invalid attribute * remove duplicate markup * style log in to content in hamburger nav * fix error * fix errors * fix error * test edit * fix some lint errors in the existing code * remove test style * resolve conflicts between utilNav.js and mainNavHamburger.js * remove duplicate markup * fix conflicts between 2 utlity content displays * set container size for utility container in hamburger menu on load * hide utility nav content when sub menu in main nav is open * remove unnecessary aria-label from hamburger main nav * hide hamburger menu at resizing window in mix over 841 * Hide hamburger menu when window size is resized to over 840 while hamburger menu is open. * adjustment for Drupal output * test edit * add changelog for DP-17154 * remove box-shadow from utility nav item in hamburger menu * setting up to close sub mneu as opening the utility nav content * set up focus on the search box in the hamburger menu by clicking the search icon on the utility nav bar * clean up unnecessary tabindex and aria-label * fix typo * setting up closure with esc key * adjust focsus issue as menu open/close * fix tabindex at closing menu button * update menu button label in screen size smaller than 620px * set the menu button to line up with the state seal on the left regardless of the screen width. * add changelog for Dp-19335 * expand close button width on the blue bar * add changelog for DP-19330 * fix lint error * Update DP-19330.yml * Updating reference screenshots * clean up comments * DP-19331 Set the nav bar height consistent in any screen sizes (#1115) * test edit * fix the dropdown visibility to keybord and screen readers maintaiing the show/hide animation effect. * fix the dropdown visibility to keybord and screen readers maintaiing the show/hide animation effect. * comment out the condition causing the keyboard trap issue with the menu button * correct aria-hidden placement for the dropdown * add jumpToSearch functioin * disable mainNavMixed.js to avoid override mainNavHamburger.js * menu button label edit * add chevron to direct link in main nav top level * correct aria-hidden for + icon container * clean up menu button label variables * adjust icons for link and button in hamburger menu * separate hamburger utility nav style from utility-nav.scss * match utility nav in hamburger menu to main nav style * add open/close behavior to util nav in hamburger menu * separate hamburger nav utlity nav style separate from utility-nav.scss * reverting merge conflict fix 1 * reverting merge conflict fix 2 * fix search access icon in page view * fix lint errors * lint error fix * fix the hidden utility content height * correct target container for utility content * adjust vertical positioning of the menu button text * move back original styles belong to utility_nav.scss * correct class in utility item * set up open/close behaviors for wide/util nav bar 'log in to' * set up open/close behaviors for narrow/hamburger menu 'log in to * fix conflict between 'log in to' buttons * uncomment test style * set focus between menu button, hamburger menu container, jump to search button and search input * test edit * fix syntax error * merge hamburger and mix template and scss to minimize duplicate. * clean up duplicate * merge mainNavMixed.js to mainNavHamburger.js * fix width for log in to content * fix lint errors * lint error fix * fix positioning of the hamburger menu container * smooth open/close behavior of log in to content in wide version * adjust open/close behavior of log in to content in wide version * remove invalid attribute * remove duplicate markup * style log in to content in hamburger nav * fix error * fix errors * fix error * test edit * fix some lint errors in the existing code * remove test style * resolve conflicts between utilNav.js and mainNavHamburger.js * remove duplicate markup * fix conflicts between 2 utlity content displays * set container size for utility container in hamburger menu on load * hide utility nav content when sub menu in main nav is open * remove unnecessary aria-label from hamburger main nav * hide hamburger menu at resizing window in mix over 841 * Hide hamburger menu when window size is resized to over 840 while hamburger menu is open. * adjustment for Drupal output * test edit * add changelog for DP-17154 * remove box-shadow from utility nav item in hamburger menu * setting up to close sub mneu as opening the utility nav content * set up focus on the search box in the hamburger menu by clicking the search icon on the utility nav bar * clean up unnecessary tabindex and aria-label * fix typo * setting up closure with esc key * adjust focsus issue as menu open/close * fix tabindex at closing menu button * set the utlity nav bar height consistent regardless screensize * remove test style * add changelog for DP-19331 * lint error fix * Updating reference screenshots * clean up comments * fix lint error * fix for backstop error * Fix indentation. * DP-19332 The nav bar positioning (#1118) * test edit * fix the dropdown visibility to keybord and screen readers maintaiing the show/hide animation effect. * fix the dropdown visibility to keybord and screen readers maintaiing the show/hide animation effect. * comment out the condition causing the keyboard trap issue with the menu button * correct aria-hidden placement for the dropdown * add jumpToSearch functioin * disable mainNavMixed.js to avoid override mainNavHamburger.js * menu button label edit * add chevron to direct link in main nav top level * correct aria-hidden for + icon container * clean up menu button label variables * adjust icons for link and button in hamburger menu * separate hamburger utility nav style from utility-nav.scss * match utility nav in hamburger menu to main nav style * add open/close behavior to util nav in hamburger menu * separate hamburger nav utlity nav style separate from utility-nav.scss * reverting merge conflict fix 1 * reverting merge conflict fix 2 * fix search access icon in page view * fix lint errors * lint error fix * fix the hidden utility content height * correct target container for utility content * adjust vertical positioning of the menu button text * move back original styles belong to utility_nav.scss * correct class in utility item * set up open/close behaviors for wide/util nav bar 'log in to' * set up open/close behaviors for narrow/hamburger menu 'log in to * fix conflict between 'log in to' buttons * uncomment test style * set focus between menu button, hamburger menu container, jump to search button and search input * test edit * fix syntax error * merge hamburger and mix template and scss to minimize duplicate. * clean up duplicate * merge mainNavMixed.js to mainNavHamburger.js * fix width for log in to content * fix lint errors * lint error fix * fix positioning of the hamburger menu container * smooth open/close behavior of log in to content in wide version * adjust open/close behavior of log in to content in wide version * remove invalid attribute * remove duplicate markup * style log in to content in hamburger nav * fix error * fix errors * fix error * test edit * fix some lint errors in the existing code * remove test style * resolve conflicts between utilNav.js and mainNavHamburger.js * remove duplicate markup * fix conflicts between 2 utlity content displays * set container size for utility container in hamburger menu on load * hide utility nav content when sub menu in main nav is open * remove unnecessary aria-label from hamburger main nav * hide hamburger menu at resizing window in mix over 841 * Hide hamburger menu when window size is resized to over 840 while hamburger menu is open. * adjustment for Drupal output * test edit * add changelog for DP-17154 * remove box-shadow from utility nav item in hamburger menu * setting up to close sub mneu as opening the utility nav content * set up focus on the search box in the hamburger menu by clicking the search icon on the utility nav bar * clean up unnecessary tabindex and aria-label * fix typo * setting up closure with esc key * adjust focsus issue as menu open/close * fix tabindex at closing menu button * set the nav bar below the site wide alert * set the nav bar position below the site wide alert * add changelog for DP-19332 * fix lint error * Updating reference screenshots * clean up comments * add a new line to the end of the file * add site wide alert to hamburger home page sample * set the site wide alert above the blue bar. * clean up comments * fix backstop errors * Updating reference screenshots * Patternlab/DP-19336 offscreen menu fixes (#1128) * Several JS error fixes - DP-19336 * Fixed additional JS errors in hamburger menu - DP-19336 * Removed closeSubMenu behavior - DP-19336 * Added changelog - DP-19336 * Updated references - DP-19336 * Revert "Removed closeSubMenu behavior - DP-19336" This reverts commit d138bbe. * Revert "Revert "Removed closeSubMenu behavior - DP-19336"" This reverts commit ebbdb13. * potential fix for hamburger menu height - DP-19336 * switched observer height - DP-19336 * added both dom loaded and observed height - DP-19336 * Added observer and window load events to add padding to menu when alerts available - DP-19336 * Added styles for when emergency alert not present - DP-19336 * Revert "Revert "Revert "Removed closeSubMenu behavior - DP-19336""" This reverts commit 7a6c5e8. * Adjust syntax for JS fixes - DP-19336 * Fixed stylelint errors - DP-19336 * Accounting for AJAX load of alerts - DP-19336 * Updated mobileNav check - DP-19336 * Fixed issues caused by fresh merge - DP-19336 * Updated comment - DP-19336 * Some additional cleanup for mobile devices - DP-19336 * Fixed search button check - DP-19336 * Add padding only for wider breakpoints - DP-19336 * Fixed stylelint issue - DP-19336 * Removed buttonLabel - DP-19336 * Added additional value checks in other hamburger code - DP-19336 * DP-19354 Search button behavior (#1120) * test edit * fix the dropdown visibility to keybord and screen readers maintaiing the show/hide animation effect. * fix the dropdown visibility to keybord and screen readers maintaiing the show/hide animation effect. * comment out the condition causing the keyboard trap issue with the menu button * correct aria-hidden placement for the dropdown * add jumpToSearch functioin * disable mainNavMixed.js to avoid override mainNavHamburger.js * menu button label edit * add chevron to direct link in main nav top level * correct aria-hidden for + icon container * clean up menu button label variables * adjust icons for link and button in hamburger menu * separate hamburger utility nav style from utility-nav.scss * match utility nav in hamburger menu to main nav style * add open/close behavior to util nav in hamburger menu * separate hamburger nav utlity nav style separate from utility-nav.scss * reverting merge conflict fix 1 * reverting merge conflict fix 2 * fix search access icon in page view * fix lint errors * lint error fix * fix the hidden utility content height * correct target container for utility content * adjust vertical positioning of the menu button text * move back original styles belong to utility_nav.scss * correct class in utility item * set up open/close behaviors for wide/util nav bar 'log in to' * set up open/close behaviors for narrow/hamburger menu 'log in to * fix conflict between 'log in to' buttons * uncomment test style * set focus between menu button, hamburger menu container, jump to search button and search input * test edit * fix syntax error * merge hamburger and mix template and scss to minimize duplicate. * clean up duplicate * merge mainNavMixed.js to mainNavHamburger.js * fix width for log in to content * fix lint errors * lint error fix * fix positioning of the hamburger menu container * smooth open/close behavior of log in to content in wide version * adjust open/close behavior of log in to content in wide version * remove invalid attribute * remove duplicate markup * style log in to content in hamburger nav * fix error * fix errors * fix error * test edit * fix some lint errors in the existing code * remove test style * resolve conflicts between utilNav.js and mainNavHamburger.js * remove duplicate markup * fix conflicts between 2 utlity content displays * set container size for utility container in hamburger menu on load * hide utility nav content when sub menu in main nav is open * remove unnecessary aria-label from hamburger main nav * hide hamburger menu at resizing window in mix over 841 * Hide hamburger menu when window size is resized to over 840 while hamburger menu is open. * adjustment for Drupal output * test edit * add changelog for DP-17154 * remove box-shadow from utility nav item in hamburger menu * setting up to close sub mneu as opening the utility nav content * set up focus on the search box in the hamburger menu by clicking the search icon on the utility nav bar * clean up unnecessary tabindex and aria-label * fix typo * setting up closure with esc key * adjust focsus issue as menu open/close * fix tabindex at closing menu button * change behavior of search button when menu is open * replace functions with arrow function expressions * add changelog for Dp-19354 * fix lint error * Updating reference screenshots * clean up comments * add autofocus attribute to searchbox in hamburger menu * change search input type from 'text' to 'search' * add inputype to search input * fix menu display with ios11 * ios focus fix test edit * ios issue test edit 2 * fix ios keyboard display issue * Added back checks - DP-19354 * disable ios default styles for the search input to ensure Mayflower style * remove test comment Co-authored-by: Tom Fleming <[email protected]> * DP-19337 Open/close behaviors in the hamburger menu (#1131) * test edit * fix the dropdown visibility to keybord and screen readers maintaiing the show/hide animation effect. * fix the dropdown visibility to keybord and screen readers maintaiing the show/hide animation effect. * comment out the condition causing the keyboard trap issue with the menu button * correct aria-hidden placement for the dropdown * add jumpToSearch functioin * disable mainNavMixed.js to avoid override mainNavHamburger.js * menu button label edit * add chevron to direct link in main nav top level * correct aria-hidden for + icon container * clean up menu button label variables * adjust icons for link and button in hamburger menu * separate hamburger utility nav style from utility-nav.scss * match utility nav in hamburger menu to main nav style * add open/close behavior to util nav in hamburger menu * separate hamburger nav utlity nav style separate from utility-nav.scss * reverting merge conflict fix 1 * reverting merge conflict fix 2 * fix search access icon in page view * fix lint errors * lint error fix * fix the hidden utility content height * correct target container for utility content * adjust vertical positioning of the menu button text * move back original styles belong to utility_nav.scss * correct class in utility item * set up open/close behaviors for wide/util nav bar 'log in to' * set up open/close behaviors for narrow/hamburger menu 'log in to * fix conflict between 'log in to' buttons * uncomment test style * set focus between menu button, hamburger menu container, jump to search button and search input * test edit * fix syntax error * merge hamburger and mix template and scss to minimize duplicate. * clean up duplicate * merge mainNavMixed.js to mainNavHamburger.js * fix width for log in to content * fix lint errors * lint error fix * fix positioning of the hamburger menu container * smooth open/close behavior of log in to content in wide version * adjust open/close behavior of log in to content in wide version * remove invalid attribute * remove duplicate markup * style log in to content in hamburger nav * fix error * fix errors * fix error * test edit * fix some lint errors in the existing code * remove test style * resolve conflicts between utilNav.js and mainNavHamburger.js * remove duplicate markup * fix conflicts between 2 utlity content displays * set container size for utility container in hamburger menu on load * hide utility nav content when sub menu in main nav is open * remove unnecessary aria-label from hamburger main nav * hide hamburger menu at resizing window in mix over 841 * Hide hamburger menu when window size is resized to over 840 while hamburger menu is open. * adjustment for Drupal output * test edit * add changelog for DP-17154 * remove box-shadow from utility nav item in hamburger menu * setting up to close sub mneu as opening the utility nav content * set up focus on the search box in the hamburger menu by clicking the search icon on the utility nav bar * clean up unnecessary tabindex and aria-label * fix typo * setting up closure with esc key * adjust focsus issue as menu open/close * fix tabindex at closing menu button * add bottom border to 'log in to...' content box * remove unnecessary line * test edit * animation fix with util nav content * separate utility nav in hamburger nav from utilNav.js * remove unnecessary lines for open/close util. content function copied from open/close sub menu function * add closeSubmenu at opening util content * modify susubmenu closing animation at opening util. nav content * add a condition to che ck if any open submenu to closeSubmenu() * test edit * slow down closing submenu speed * clean up comments * add changelog for DP-19337 * fix lint error * Resolve conflict. * put back nav bar padding change in DP-19335 * clean up comments * menu botton positioning * fix format * fix menu button label which is not working in patternlab/DP-17200-add-horizontal-nav-code-branch * expand close button to fill the blue bar * fix lint error * fix lint error * slow the log-in-to content open/close animation * clean up comments * fix typo * fix lint errors * fix rendering issues causing backstop errors Co-authored-by: Tom Fleming <[email protected]> * DP-17155 hamburger nav keyboard navigation (#1141) * test edit * fix the dropdown visibility to keybord and screen readers maintaiing the show/hide animation effect. * fix the dropdown visibility to keybord and screen readers maintaiing the show/hide animation effect. * comment out the condition causing the keyboard trap issue with the menu button * correct aria-hidden placement for the dropdown * add jumpToSearch functioin * disable mainNavMixed.js to avoid override mainNavHamburger.js * menu button label edit * add chevron to direct link in main nav top level * correct aria-hidden for + icon container * clean up menu button label variables * adjust icons for link and button in hamburger menu * separate hamburger utility nav style from utility-nav.scss * match utility nav in hamburger menu to main nav style * add open/close behavior to util nav in hamburger menu * separate hamburger nav utlity nav style separate from utility-nav.scss * reverting merge conflict fix 1 * reverting merge conflict fix 2 * fix search access icon in page view * fix lint errors * lint error fix * fix the hidden utility content height * correct target container for utility content * adjust vertical positioning of the menu button text * move back original styles belong to utility_nav.scss * correct class in utility item * set up open/close behaviors for wide/util nav bar 'log in to' * set up open/close behaviors for narrow/hamburger menu 'log in to * fix conflict between 'log in to' buttons * uncomment test style * set focus between menu button, hamburger menu container, jump to search button and search input * test edit * fix syntax error * merge hamburger and mix template and scss to minimize duplicate. * clean up duplicate * merge mainNavMixed.js to mainNavHamburger.js * fix width for log in to content * fix lint errors * lint error fix * fix positioning of the hamburger menu container * smooth open/close behavior of log in to content in wide version * adjust open/close behavior of log in to content in wide version * remove invalid attribute * remove duplicate markup * style log in to content in hamburger nav * fix error * fix errors * fix error * test edit * fix some lint errors in the existing code * remove test style * resolve conflicts between utilNav.js and mainNavHamburger.js * remove duplicate markup * fix conflicts between 2 utlity content displays * set container size for utility container in hamburger menu on load * hide utility nav content when sub menu in main nav is open * remove unnecessary aria-label from hamburger main nav * hide hamburger menu at resizing window in mix over 841 * Hide hamburger menu when window size is resized to over 840 while hamburger menu is open. * adjustment for Drupal output * test edit * add changelog for DP-17154 * remove box-shadow from utility nav item in hamburger menu * setting up to close sub mneu as opening the utility nav content * set up focus on the search box in the hamburger menu by clicking the search icon on the utility nav bar * clean up unnecessary tabindex and aria-label * fix typo * setting up closure with esc key * adjust focsus issue as menu open/close * fix tabindex at closing menu button * add bottom border to 'log in to...' content box * remove unnecessary line * test edit * animation fix with util nav content * separate utility nav in hamburger nav from utilNav.js * remove unnecessary lines for open/close util. content function copied from open/close sub menu function * add closeSubmenu at opening util content * modify susubmenu closing animation at opening util. nav content * add a condition to che ck if any open submenu to closeSubmenu() * test edit * slow down closing submenu speed * clean up comments * add changelog for DP-19337 * fix lint error * Resolve conflict. * put back nav bar padding change in DP-19335 * clean up comments * menu botton positioning * fix format * fix menu button label which is not working in patternlab/DP-17200-add-horizontal-nav-code-branch * expand close button to fill the blue bar * fix lint error * fix lint error * slow the log-in-to content open/close animation * set focus on the hamburger menu from the first focusable item in the menu container with shift-tab. * keyboard navigation setting focus test edit * circle back focus to the first top menu button from the last focusable element in the menu * add condition to check button or link on top menu * fix conflicts with null last submenu link * set up escape + focus behaviors * additional patterns for escape behavior * add changelog for DP-17155 * add changelog the PR number * cleanup after resolving merge conflicts * remove menu label text from span.ma__header__hamburger__menu-text in header-mixed.twig * merge conflict clean up 2 * merge conflicts clean up 3 * fix backstop errors * switch an item to check null * fix setting focus on body, not menu button on load * DP-19683 Adjust overlay position (#1152) * set overlay below the blue nav bar * add changelog for DP-19683 * remove a duplicate variable definition from cleaning up merge conflicts * fix backstop failures from rendering error * DP-19738 IE11 issues (#1157) * add polyfill for NodeList.prototype.forEach * fix esc key issue with IE11 * add condition to check null for result.display * add escape key definition of 'e.key === Esc' for IE11 support * add changelog for DP-19738 * DP-19782 flyout scrolling (#1160) * fix the bottom cut off in the flyout * set a fomula to calculate the height of the flyout * test edit * test edit2 * adding a height calculation formula to the blue nav bar with screen size less than 841px * test edit3 * Fixed narrow utility nav for tablet sizes - DP-19782 * remove note comment * clean up comments * Fixed menu button scrolling to top and set scroll to top to show alerts button on smaller screens - DP-19782 * Changed height check to not use height at page load - DP-19782 * Set up with correct positioning and animated scroll - DP-19782 * Added back old method - DP-19782 * Replaced else statement - DP-19782 * Fixed extra height - DP-19782 * Revert "Fixed extra height - DP-19782" This reverts commit 3b4d6ac. * Keep menu closing behavior on resize in - DP-19872 Co-authored-by: Tom Fleming <[email protected]> * DP-19866: Scroll issue fix (#1174) * DP-19866: Scroll issue fix * DP-19866: Scroll to menu for desktop * DP-19877: Height of blue global nav bar is not tall enough on small screens (#1179) * DP-19877: Global nav blue bar height 40px => 44px * DP-19877: Global nav blue bar height 40px => 44px * DP-19739 voiceover issues (#1166) * correct roles in main menu elements * disable ESC default behavior in Safari * fix a lint error * fix visibility of utility menu content to screen readers * fix lint error * set up down arrow navigation to narrow util nav content * adding uparrow navigation for narrow util content links * test edit * up arrow adjustment for index and current item mismatch * add up arrow navigation for util content links * add changelog for DP-19739 * move focus from the menu button to the menu container(=flyout) with tab (#1159) * move focus from the menu button to the menu container(=flyout) with tab * add changelog for DP-19783 * test edit * fix lint error * test edit 2 * test edit3 * tabbing fix for safari * remove test styles * DP-19870: Fix scroll issue with off screen menu button scrolling to the top before moving to correct location (#1175) * DP-19866: Scroll issue fix * DP-19866: Scroll to menu for desktop * DP-19870: Scroll issue fix on mobile devices * DP-19868: Search icon issue fox for Apple devices * DP-19867: Search icon issue fox for Android devices * DP-19889: Global nav scroll should stop at bottom and not close on its own * Swapped back in JS-only menu animation - DP-19870 * Modified offsetting to work with Desktop - DP-19870 * Fixed scroll jump from top issue - DP-19870 * Made search button selection smoother - DP-19870 * Removed faking Safari input to get keyboard to pop up - DP-19868 * small change - DP-19868 * Some more changes - DP-19868 * One more open menu change and console log output - DP-19868 * Updating reference screenshots Co-authored-by: Tom Fleming <[email protected]> Co-authored-by: Yukiko Gannett <[email protected]> * DP-19953 Style the log in to content in the hamburger menu (#1182) * style the log in to content in the hamburger menu * add changelog for DP-19953 * DP-19879 Adjust overlay position and timing (#1180) * DP-19866: Scroll issue fix * DP-19866: Scroll to menu for desktop * DP-19870: Scroll issue fix on mobile devices * DP-19868: Search icon issue fox for Apple devices * DP-19867: Search icon issue fox for Android devices * DP-19889: Global nav scroll should stop at bottom and not close on its own * Swapped back in JS-only menu animation - DP-19870 * Modified offsetting to work with Desktop - DP-19870 * Fixed scroll jump from top issue - DP-19870 * adjust overlay position and timing * add changelog for DP-19879 * Made search button selection smoother - DP-19870 * overlay position adjustment per device and browser * remove feature to adjust overlay positioning as alert accordinon opens/closes while the menu is open * udpate changelog * Updating reference screenshots Co-authored-by: abaghdasaryan <[email protected]> Co-authored-by: Tom Fleming <[email protected]> * DP-19889 the menu scroll issue in iphone (#1183) * fix js error and lint issues * fix the menu closing with vertical scroll in iphone * add clean up task on body at closing menu * add changelog for DP-19889 * DP-19984 Style adjustment for links in the flyout menu (#1184) * remove chevron from link and adjust vertical alignment of arrow icon on the last sub menu item * add changelog for DP-19984 * Removed touchend events to prevent observed open on scroll - DP-19878 (#1185) * Removed touchend events to prevent observed open on scroll - DP-19878 * Added changelog - DP-19878 * DP-19987: log in to menu width (#1186) * Fixed width issue with log in to menu - DP-19987 * Added changelog - DP-19987 * DP-20029: Fixed search button behavior caused by resize events on phones (#1187) * Fixed search button behavior caused by resize events on phones - DP-20029 * Added changelog - DP-20029 * DP-20039 fix Safari closing issue (#1189) * Removed CSS causing Safari to crash in iOS12 #believeitornot * Added changelog - DP-20039 * DP-20038 Alert position and Menu scroll (#1190) * lock the alert scrolled position when the menu opens and reltains it when the menu closes. * fix lint issue * set nav container height * clean up comments * add changelog for DP-20037 and DP-20038 * set width to body * DP-20055 fix Firefox overlay (#1192) * Fixed Firefox-specific JS that was causing overlay issues - DP-20055 * Added changelog - DP-20055 * DP-20054 S7 search button (#1191) * Set timeout higher for jump to search to work on Galaxy S7 - DP-20054 * Added changelog - DP-20054 * Added changelog - DP-20054 * DP-20085 Fixed sticky TOC for new global nav (#1194) * Fixed sticky TOC to work with non-sticky menu - DP-20085 * Added changelog - DP-20085 * DP-20080/20096 ios scrolling issue + hamburger menu js cleanup (#1196) * remove unused function * merge commonOpenMenuTasks() to openMenu() * ios menuoverlay offset adjustment * add notes * Removes a few setTimeout functions, changes window scroll to be the same for all browsers. * clean up test code and unused functions * format cleanup * remove unused function * add change log for DP-20080 and DP-20096 Co-authored-by: smurrayatwork <[email protected]> * DP-20092 Fix menu issues affecting COVID-19 unemployment page with new global nav (#1197) * Added bind for tabbing function body truncation - DP-20092 * Added changelog * DP-20091 Reorder z-index values for overlay components (#1198) * change z-index value for the feedback button * update z-index value for the navigation components to be consistent * update z-index values for the menu container and the overlay * clean up comments * adjust z-index variables for designated values * add changelog for DP-20091 * clean up comments * Update _fixed-feedback-button.scss * Clean up comments. * Removed iPhone-specific overlay JS - DP-20091 * adjust z-index for sticky nav * adjust sticky toc positioning in screen width 840 and less * add a condition to check null item for original mobile main nav * fix original mobile nav open/close function * set a condition to be specific for original mobile main nav * put back removed block for testing * set up specific height value for the menu container in iphone Co-authored-by: Tom Fleming <[email protected]> * DP-20163 Remove extra space between the search component and the main menu in the menu container (#1201) * remove exta space between the search box and the main nav in the menu container * add changelog for DP-20163 * DP-20096 timing functioin cleanup (#1202) * remove unused function * merge commonOpenMenuTasks() to openMenu() * ios menuoverlay offset adjustment * add notes * Removes a few setTimeout functions, changes window scroll to be the same for all browsers. * clean up test code and unused functions * format cleanup * remove unused function * add change log for DP-20080 and DP-20096 * DP-20096: Adds support for scrolling into view menu items in hambuger menu. * DP-20096: Fixes bug causing submenu to close when submenu item clicked. * add a no-alert rule for lockPage(). * remove test output code * move 'positioin: fixed;' to no alert rule * Fixes bug causing page to scroll when clicking submenu items on desktop. Co-authored-by: Yukiko Gannett <[email protected]> Co-authored-by: smurrayatwork <[email protected]> * DP-20176 Utility nav item container open/close state icon (#1205) * put back missing DP-20085 sticky TOC fix * fix util nav button state via keyboard navigation in the menu container * add changelog for DP-20176 * Update DP-20176.yml * DP-20181 Focus from the linked logo in the menu to the menu button (#1206) * fix focus order from the linked logo in the menu to menu button * add changelog for DP-20181 * DP-20090 menu search align (#1200) * Adjusted styling to align menu text and icon - DP-20090 * Second pass at menu icon centering - DP-20090 * Added changelog - DP-20090 * Address flex issues for iOS less than 11 - DP-20090 * adjusted class name - DP-20090 Co-authored-by: Yukiko Gannett <[email protected]> * DP-20201: Fix scroll issues noticed on iOS (#1210) * Fixed scroll issues noticed on iPads - DP-20201 * Added changelog - DP-20201 * DP-20119 Update the global nav in all page (#1213) * switch main navigation to new one * update home page samples * adjust z-index for sticky table header to make the menu button clickable * add changelog for DP-20119 * Updating reference screenshots with the new global nav * DP-20209 iOS scroll issue (#1211) * Fixed scroll issue for iOS and hopefully didn't break other devices - DP-20209 * Added changelog - DP-20209 * Revert "Added changelog - DP-20209" This reverts commit 6f4f29f. * Revert "Revert "Added changelog - DP-20209"" This reverts commit 4c55ad5. * Revert "Fixed scroll issue for iOS and hopefully didn't break other devices - DP-20209" This reverts commit 40dc92b. * Revert "Revert "Fixed scroll issue for iOS and hopefully didn't break other devices - DP-20209"" This reverts commit c9592a8. * Addressed issues with iPhone 7 crashes, getting menu height to show everything - DP-20209 * Changed offset height to nav - DP-20209 * fix for iPads - DP-20209 * Changed how some calculated variables are stored - DP-20209 * Fixed scrollTo issue with mainNavHamburger.js - DP-17200 Co-authored-by: Yukiko Gannett <[email protected]> Co-authored-by: Tom Fleming <[email protected]> Co-authored-by: smurrayatwork <[email protected]>
tom-fleming
added a commit
that referenced
this pull request
Oct 20, 2020
* DP-17200 Add horizontal nav code into global nav branch so it can be used on home page (#1094) * Merging Hamburger nav functionality * Fixing hamburger menu search icon position * Adding MD files to describe the templates * Updating reference screenshots * Adding header mixed template * Adding header mixed template, adding covid 19 sample url * Stylelint fixes * Adding covid link to hamburger template * Adding new homepage template with mixed header * Adding changelog * Remove unused code from header mixed template * Google translate menu tiem reverted back * Google translate menu item reverted back for hamburger header * Adding missing styles * Fixing linting issues * Fixing styles for fixed header * Fixed position nav fix * Fixing hamburger menu open nav position * Fixing hamburger menu open nav position on desktop * DP-19335 Menu button fixes (#1116) * test edit * fix the dropdown visibility to keybord and screen readers maintaiing the show/hide animation effect. * fix the dropdown visibility to keybord and screen readers maintaiing the show/hide animation effect. * comment out the condition causing the keyboard trap issue with the menu button * correct aria-hidden placement for the dropdown * add jumpToSearch functioin * disable mainNavMixed.js to avoid override mainNavHamburger.js * menu button label edit * add chevron to direct link in main nav top level * correct aria-hidden for + icon container * clean up menu button label variables * adjust icons for link and button in hamburger menu * separate hamburger utility nav style from utility-nav.scss * match utility nav in hamburger menu to main nav style * add open/close behavior to util nav in hamburger menu * separate hamburger nav utlity nav style separate from utility-nav.scss * reverting merge conflict fix 1 * reverting merge conflict fix 2 * fix search access icon in page view * fix lint errors * lint error fix * fix the hidden utility content height * correct target container for utility content * adjust vertical positioning of the menu button text * move back original styles belong to utility_nav.scss * correct class in utility item * set up open/close behaviors for wide/util nav bar 'log in to' * set up open/close behaviors for narrow/hamburger menu 'log in to * fix conflict between 'log in to' buttons * uncomment test style * set focus between menu button, hamburger menu container, jump to search button and search input * test edit * fix syntax error * merge hamburger and mix template and scss to minimize duplicate. * clean up duplicate * merge mainNavMixed.js to mainNavHamburger.js * fix width for log in to content * fix lint errors * lint error fix * fix positioning of the hamburger menu container * smooth open/close behavior of log in to content in wide version * adjust open/close behavior of log in to content in wide version * remove invalid attribute * remove duplicate markup * style log in to content in hamburger nav * fix error * fix errors * fix error * test edit * fix some lint errors in the existing code * remove test style * resolve conflicts between utilNav.js and mainNavHamburger.js * remove duplicate markup * fix conflicts between 2 utlity content displays * set container size for utility container in hamburger menu on load * hide utility nav content when sub menu in main nav is open * remove unnecessary aria-label from hamburger main nav * hide hamburger menu at resizing window in mix over 841 * Hide hamburger menu when window size is resized to over 840 while hamburger menu is open. * adjustment for Drupal output * test edit * add changelog for DP-17154 * remove box-shadow from utility nav item in hamburger menu * setting up to close sub mneu as opening the utility nav content * set up focus on the search box in the hamburger menu by clicking the search icon on the utility nav bar * clean up unnecessary tabindex and aria-label * fix typo * setting up closure with esc key * adjust focsus issue as menu open/close * fix tabindex at closing menu button * update menu button label in screen size smaller than 620px * set the menu button to line up with the state seal on the left regardless of the screen width. * add changelog for Dp-19335 * fix lint error * Updating reference screenshots * remove deplicated line * clean up comments * DP-17154 header change with new global nav (#1099) * test edit * fix the dropdown visibility to keybord and screen readers maintaiing the show/hide animation effect. * fix the dropdown visibility to keybord and screen readers maintaiing the show/hide animation effect. * comment out the condition causing the keyboard trap issue with the menu button * correct aria-hidden placement for the dropdown * add jumpToSearch functioin * disable mainNavMixed.js to avoid override mainNavHamburger.js * menu button label edit * add chevron to direct link in main nav top level * correct aria-hidden for + icon container * clean up menu button label variables * adjust icons for link and button in hamburger menu * separate hamburger utility nav style from utility-nav.scss * match utility nav in hamburger menu to main nav style * add open/close behavior to util nav in hamburger menu * separate hamburger nav utlity nav style separate from utility-nav.scss * reverting merge conflict fix 1 * reverting merge conflict fix 2 * fix search access icon in page view * fix lint errors * lint error fix * fix the hidden utility content height * correct target container for utility content * adjust vertical positioning of the menu button text * move back original styles belong to utility_nav.scss * correct class in utility item * set up open/close behaviors for wide/util nav bar 'log in to' * set up open/close behaviors for narrow/hamburger menu 'log in to * fix conflict between 'log in to' buttons * uncomment test style * set focus between menu button, hamburger menu container, jump to search button and search input * test edit * fix syntax error * merge hamburger and mix template and scss to minimize duplicate. * clean up duplicate * merge mainNavMixed.js to mainNavHamburger.js * fix width for log in to content * fix lint errors * lint error fix * fix positioning of the hamburger menu container * smooth open/close behavior of log in to content in wide version * adjust open/close behavior of log in to content in wide version * remove invalid attribute * remove duplicate markup * style log in to content in hamburger nav * fix error * fix errors * fix error * test edit * fix some lint errors in the existing code * remove test style * resolve conflicts between utilNav.js and mainNavHamburger.js * remove duplicate markup * fix conflicts between 2 utlity content displays * set container size for utility container in hamburger menu on load * hide utility nav content when sub menu in main nav is open * remove unnecessary aria-label from hamburger main nav * hide hamburger menu at resizing window in mix over 841 * Hide hamburger menu when window size is resized to over 840 while hamburger menu is open. * adjustment for Drupal output * test edit * add changelog for DP-17154 * remove box-shadow from utility nav item in hamburger menu * setting up to close sub mneu as opening the utility nav content * set up focus on the search box in the hamburger menu by clicking the search icon on the utility nav bar * clean up unnecessary tabindex and aria-label * fix typo * setting up closure with esc key * adjust focsus issue as menu open/close * fix tabindex at closing menu button * fix lint error * Updating reference screenshots * clean up comments * remove unused variable * remove backstop reference * copy screenshots from DP-17200 * add missing reference for backstop * add missing reference for backstop 2 * adjust the header bar padding to meet DP-17200 * DP-19330 Expand the menu button width with "close" label (#1119) * test edit * fix the dropdown visibility to keybord and screen readers maintaiing the show/hide animation effect. * fix the dropdown visibility to keybord and screen readers maintaiing the show/hide animation effect. * comment out the condition causing the keyboard trap issue with the menu button * correct aria-hidden placement for the dropdown * add jumpToSearch functioin * disable mainNavMixed.js to avoid override mainNavHamburger.js * menu button label edit * add chevron to direct link in main nav top level * correct aria-hidden for + icon container * clean up menu button label variables * adjust icons for link and button in hamburger menu * separate hamburger utility nav style from utility-nav.scss * match utility nav in hamburger menu to main nav style * add open/close behavior to util nav in hamburger menu * separate hamburger nav utlity nav style separate from utility-nav.scss * reverting merge conflict fix 1 * reverting merge conflict fix 2 * fix search access icon in page view * fix lint errors * lint error fix * fix the hidden utility content height * correct target container for utility content * adjust vertical positioning of the menu button text * move back original styles belong to utility_nav.scss * correct class in utility item * set up open/close behaviors for wide/util nav bar 'log in to' * set up open/close behaviors for narrow/hamburger menu 'log in to * fix conflict between 'log in to' buttons * uncomment test style * set focus between menu button, hamburger menu container, jump to search button and search input * test edit * fix syntax error * merge hamburger and mix template and scss to minimize duplicate. * clean up duplicate * merge mainNavMixed.js to mainNavHamburger.js * fix width for log in to content * fix lint errors * lint error fix * fix positioning of the hamburger menu container * smooth open/close behavior of log in to content in wide version * adjust open/close behavior of log in to content in wide version * remove invalid attribute * remove duplicate markup * style log in to content in hamburger nav * fix error * fix errors * fix error * test edit * fix some lint errors in the existing code * remove test style * resolve conflicts between utilNav.js and mainNavHamburger.js * remove duplicate markup * fix conflicts between 2 utlity content displays * set container size for utility container in hamburger menu on load * hide utility nav content when sub menu in main nav is open * remove unnecessary aria-label from hamburger main nav * hide hamburger menu at resizing window in mix over 841 * Hide hamburger menu when window size is resized to over 840 while hamburger menu is open. * adjustment for Drupal output * test edit * add changelog for DP-17154 * remove box-shadow from utility nav item in hamburger menu * setting up to close sub mneu as opening the utility nav content * set up focus on the search box in the hamburger menu by clicking the search icon on the utility nav bar * clean up unnecessary tabindex and aria-label * fix typo * setting up closure with esc key * adjust focsus issue as menu open/close * fix tabindex at closing menu button * update menu button label in screen size smaller than 620px * set the menu button to line up with the state seal on the left regardless of the screen width. * add changelog for Dp-19335 * expand close button width on the blue bar * add changelog for DP-19330 * fix lint error * Update DP-19330.yml * Updating reference screenshots * clean up comments * DP-19331 Set the nav bar height consistent in any screen sizes (#1115) * test edit * fix the dropdown visibility to keybord and screen readers maintaiing the show/hide animation effect. * fix the dropdown visibility to keybord and screen readers maintaiing the show/hide animation effect. * comment out the condition causing the keyboard trap issue with the menu button * correct aria-hidden placement for the dropdown * add jumpToSearch functioin * disable mainNavMixed.js to avoid override mainNavHamburger.js * menu button label edit * add chevron to direct link in main nav top level * correct aria-hidden for + icon container * clean up menu button label variables * adjust icons for link and button in hamburger menu * separate hamburger utility nav style from utility-nav.scss * match utility nav in hamburger menu to main nav style * add open/close behavior to util nav in hamburger menu * separate hamburger nav utlity nav style separate from utility-nav.scss * reverting merge conflict fix 1 * reverting merge conflict fix 2 * fix search access icon in page view * fix lint errors * lint error fix * fix the hidden utility content height * correct target container for utility content * adjust vertical positioning of the menu button text * move back original styles belong to utility_nav.scss * correct class in utility item * set up open/close behaviors for wide/util nav bar 'log in to' * set up open/close behaviors for narrow/hamburger menu 'log in to * fix conflict between 'log in to' buttons * uncomment test style * set focus between menu button, hamburger menu container, jump to search button and search input * test edit * fix syntax error * merge hamburger and mix template and scss to minimize duplicate. * clean up duplicate * merge mainNavMixed.js to mainNavHamburger.js * fix width for log in to content * fix lint errors * lint error fix * fix positioning of the hamburger menu container * smooth open/close behavior of log in to content in wide version * adjust open/close behavior of log in to content in wide version * remove invalid attribute * remove duplicate markup * style log in to content in hamburger nav * fix error * fix errors * fix error * test edit * fix some lint errors in the existing code * remove test style * resolve conflicts between utilNav.js and mainNavHamburger.js * remove duplicate markup * fix conflicts between 2 utlity content displays * set container size for utility container in hamburger menu on load * hide utility nav content when sub menu in main nav is open * remove unnecessary aria-label from hamburger main nav * hide hamburger menu at resizing window in mix over 841 * Hide hamburger menu when window size is resized to over 840 while hamburger menu is open. * adjustment for Drupal output * test edit * add changelog for DP-17154 * remove box-shadow from utility nav item in hamburger menu * setting up to close sub mneu as opening the utility nav content * set up focus on the search box in the hamburger menu by clicking the search icon on the utility nav bar * clean up unnecessary tabindex and aria-label * fix typo * setting up closure with esc key * adjust focsus issue as menu open/close * fix tabindex at closing menu button * set the utlity nav bar height consistent regardless screensize * remove test style * add changelog for DP-19331 * lint error fix * Updating reference screenshots * clean up comments * fix lint error * fix for backstop error * Fix indentation. * DP-19332 The nav bar positioning (#1118) * test edit * fix the dropdown visibility to keybord and screen readers maintaiing the show/hide animation effect. * fix the dropdown visibility to keybord and screen readers maintaiing the show/hide animation effect. * comment out the condition causing the keyboard trap issue with the menu button * correct aria-hidden placement for the dropdown * add jumpToSearch functioin * disable mainNavMixed.js to avoid override mainNavHamburger.js * menu button label edit * add chevron to direct link in main nav top level * correct aria-hidden for + icon container * clean up menu button label variables * adjust icons for link and button in hamburger menu * separate hamburger utility nav style from utility-nav.scss * match utility nav in hamburger menu to main nav style * add open/close behavior to util nav in hamburger menu * separate hamburger nav utlity nav style separate from utility-nav.scss * reverting merge conflict fix 1 * reverting merge conflict fix 2 * fix search access icon in page view * fix lint errors * lint error fix * fix the hidden utility content height * correct target container for utility content * adjust vertical positioning of the menu button text * move back original styles belong to utility_nav.scss * correct class in utility item * set up open/close behaviors for wide/util nav bar 'log in to' * set up open/close behaviors for narrow/hamburger menu 'log in to * fix conflict between 'log in to' buttons * uncomment test style * set focus between menu button, hamburger menu container, jump to search button and search input * test edit * fix syntax error * merge hamburger and mix template and scss to minimize duplicate. * clean up duplicate * merge mainNavMixed.js to mainNavHamburger.js * fix width for log in to content * fix lint errors * lint error fix * fix positioning of the hamburger menu container * smooth open/close behavior of log in to content in wide version * adjust open/close behavior of log in to content in wide version * remove invalid attribute * remove duplicate markup * style log in to content in hamburger nav * fix error * fix errors * fix error * test edit * fix some lint errors in the existing code * remove test style * resolve conflicts between utilNav.js and mainNavHamburger.js * remove duplicate markup * fix conflicts between 2 utlity content displays * set container size for utility container in hamburger menu on load * hide utility nav content when sub menu in main nav is open * remove unnecessary aria-label from hamburger main nav * hide hamburger menu at resizing window in mix over 841 * Hide hamburger menu when window size is resized to over 840 while hamburger menu is open. * adjustment for Drupal output * test edit * add changelog for DP-17154 * remove box-shadow from utility nav item in hamburger menu * setting up to close sub mneu as opening the utility nav content * set up focus on the search box in the hamburger menu by clicking the search icon on the utility nav bar * clean up unnecessary tabindex and aria-label * fix typo * setting up closure with esc key * adjust focsus issue as menu open/close * fix tabindex at closing menu button * set the nav bar below the site wide alert * set the nav bar position below the site wide alert * add changelog for DP-19332 * fix lint error * Updating reference screenshots * clean up comments * add a new line to the end of the file * add site wide alert to hamburger home page sample * set the site wide alert above the blue bar. * clean up comments * fix backstop errors * Updating reference screenshots * Patternlab/DP-19336 offscreen menu fixes (#1128) * Several JS error fixes - DP-19336 * Fixed additional JS errors in hamburger menu - DP-19336 * Removed closeSubMenu behavior - DP-19336 * Added changelog - DP-19336 * Updated references - DP-19336 * Revert "Removed closeSubMenu behavior - DP-19336" This reverts commit d138bbe. * Revert "Revert "Removed closeSubMenu behavior - DP-19336"" This reverts commit ebbdb13. * potential fix for hamburger menu height - DP-19336 * switched observer height - DP-19336 * added both dom loaded and observed height - DP-19336 * Added observer and window load events to add padding to menu when alerts available - DP-19336 * Added styles for when emergency alert not present - DP-19336 * Revert "Revert "Revert "Removed closeSubMenu behavior - DP-19336""" This reverts commit 7a6c5e8. * Adjust syntax for JS fixes - DP-19336 * Fixed stylelint errors - DP-19336 * Accounting for AJAX load of alerts - DP-19336 * Updated mobileNav check - DP-19336 * Fixed issues caused by fresh merge - DP-19336 * Updated comment - DP-19336 * Some additional cleanup for mobile devices - DP-19336 * Fixed search button check - DP-19336 * Add padding only for wider breakpoints - DP-19336 * Fixed stylelint issue - DP-19336 * Removed buttonLabel - DP-19336 * Added additional value checks in other hamburger code - DP-19336 * DP-19354 Search button behavior (#1120) * test edit * fix the dropdown visibility to keybord and screen readers maintaiing the show/hide animation effect. * fix the dropdown visibility to keybord and screen readers maintaiing the show/hide animation effect. * comment out the condition causing the keyboard trap issue with the menu button * correct aria-hidden placement for the dropdown * add jumpToSearch functioin * disable mainNavMixed.js to avoid override mainNavHamburger.js * menu button label edit * add chevron to direct link in main nav top level * correct aria-hidden for + icon container * clean up menu button label variables * adjust icons for link and button in hamburger menu * separate hamburger utility nav style from utility-nav.scss * match utility nav in hamburger menu to main nav style * add open/close behavior to util nav in hamburger menu * separate hamburger nav utlity nav style separate from utility-nav.scss * reverting merge conflict fix 1 * reverting merge conflict fix 2 * fix search access icon in page view * fix lint errors * lint error fix * fix the hidden utility content height * correct target container for utility content * adjust vertical positioning of the menu button text * move back original styles belong to utility_nav.scss * correct class in utility item * set up open/close behaviors for wide/util nav bar 'log in to' * set up open/close behaviors for narrow/hamburger menu 'log in to * fix conflict between 'log in to' buttons * uncomment test style * set focus between menu button, hamburger menu container, jump to search button and search input * test edit * fix syntax error * merge hamburger and mix template and scss to minimize duplicate. * clean up duplicate * merge mainNavMixed.js to mainNavHamburger.js * fix width for log in to content * fix lint errors * lint error fix * fix positioning of the hamburger menu container * smooth open/close behavior of log in to content in wide version * adjust open/close behavior of log in to content in wide version * remove invalid attribute * remove duplicate markup * style log in to content in hamburger nav * fix error * fix errors * fix error * test edit * fix some lint errors in the existing code * remove test style * resolve conflicts between utilNav.js and mainNavHamburger.js * remove duplicate markup * fix conflicts between 2 utlity content displays * set container size for utility container in hamburger menu on load * hide utility nav content when sub menu in main nav is open * remove unnecessary aria-label from hamburger main nav * hide hamburger menu at resizing window in mix over 841 * Hide hamburger menu when window size is resized to over 840 while hamburger menu is open. * adjustment for Drupal output * test edit * add changelog for DP-17154 * remove box-shadow from utility nav item in hamburger menu * setting up to close sub mneu as opening the utility nav content * set up focus on the search box in the hamburger menu by clicking the search icon on the utility nav bar * clean up unnecessary tabindex and aria-label * fix typo * setting up closure with esc key * adjust focsus issue as menu open/close * fix tabindex at closing menu button * change behavior of search button when menu is open * replace functions with arrow function expressions * add changelog for Dp-19354 * fix lint error * Updating reference screenshots * clean up comments * add autofocus attribute to searchbox in hamburger menu * change search input type from 'text' to 'search' * add inputype to search input * fix menu display with ios11 * ios focus fix test edit * ios issue test edit 2 * fix ios keyboard display issue * Added back checks - DP-19354 * disable ios default styles for the search input to ensure Mayflower style * remove test comment Co-authored-by: Tom Fleming <[email protected]> * DP-19337 Open/close behaviors in the hamburger menu (#1131) * test edit * fix the dropdown visibility to keybord and screen readers maintaiing the show/hide animation effect. * fix the dropdown visibility to keybord and screen readers maintaiing the show/hide animation effect. * comment out the condition causing the keyboard trap issue with the menu button * correct aria-hidden placement for the dropdown * add jumpToSearch functioin * disable mainNavMixed.js to avoid override mainNavHamburger.js * menu button label edit * add chevron to direct link in main nav top level * correct aria-hidden for + icon container * clean up menu button label variables * adjust icons for link and button in hamburger menu * separate hamburger utility nav style from utility-nav.scss * match utility nav in hamburger menu to main nav style * add open/close behavior to util nav in hamburger menu * separate hamburger nav utlity nav style separate from utility-nav.scss * reverting merge conflict fix 1 * reverting merge conflict fix 2 * fix search access icon in page view * fix lint errors * lint error fix * fix the hidden utility content height * correct target container for utility content * adjust vertical positioning of the menu button text * move back original styles belong to utility_nav.scss * correct class in utility item * set up open/close behaviors for wide/util nav bar 'log in to' * set up open/close behaviors for narrow/hamburger menu 'log in to * fix conflict between 'log in to' buttons * uncomment test style * set focus between menu button, hamburger menu container, jump to search button and search input * test edit * fix syntax error * merge hamburger and mix template and scss to minimize duplicate. * clean up duplicate * merge mainNavMixed.js to mainNavHamburger.js * fix width for log in to content * fix lint errors * lint error fix * fix positioning of the hamburger menu container * smooth open/close behavior of log in to content in wide version * adjust open/close behavior of log in to content in wide version * remove invalid attribute * remove duplicate markup * style log in to content in hamburger nav * fix error * fix errors * fix error * test edit * fix some lint errors in the existing code * remove test style * resolve conflicts between utilNav.js and mainNavHamburger.js * remove duplicate markup * fix conflicts between 2 utlity content displays * set container size for utility container in hamburger menu on load * hide utility nav content when sub menu in main nav is open * remove unnecessary aria-label from hamburger main nav * hide hamburger menu at resizing window in mix over 841 * Hide hamburger menu when window size is resized to over 840 while hamburger menu is open. * adjustment for Drupal output * test edit * add changelog for DP-17154 * remove box-shadow from utility nav item in hamburger menu * setting up to close sub mneu as opening the utility nav content * set up focus on the search box in the hamburger menu by clicking the search icon on the utility nav bar * clean up unnecessary tabindex and aria-label * fix typo * setting up closure with esc key * adjust focsus issue as menu open/close * fix tabindex at closing menu button * add bottom border to 'log in to...' content box * remove unnecessary line * test edit * animation fix with util nav content * separate utility nav in hamburger nav from utilNav.js * remove unnecessary lines for open/close util. content function copied from open/close sub menu function * add closeSubmenu at opening util content * modify susubmenu closing animation at opening util. nav content * add a condition to che ck if any open submenu to closeSubmenu() * test edit * slow down closing submenu speed * clean up comments * add changelog for DP-19337 * fix lint error * Resolve conflict. * put back nav bar padding change in DP-19335 * clean up comments * menu botton positioning * fix format * fix menu button label which is not working in patternlab/DP-17200-add-horizontal-nav-code-branch * expand close button to fill the blue bar * fix lint error * fix lint error * slow the log-in-to content open/close animation * clean up comments * fix typo * fix lint errors * fix rendering issues causing backstop errors Co-authored-by: Tom Fleming <[email protected]> * DP-17155 hamburger nav keyboard navigation (#1141) * test edit * fix the dropdown visibility to keybord and screen readers maintaiing the show/hide animation effect. * fix the dropdown visibility to keybord and screen readers maintaiing the show/hide animation effect. * comment out the condition causing the keyboard trap issue with the menu button * correct aria-hidden placement for the dropdown * add jumpToSearch functioin * disable mainNavMixed.js to avoid override mainNavHamburger.js * menu button label edit * add chevron to direct link in main nav top level * correct aria-hidden for + icon container * clean up menu button label variables * adjust icons for link and button in hamburger menu * separate hamburger utility nav style from utility-nav.scss * match utility nav in hamburger menu to main nav style * add open/close behavior to util nav in hamburger menu * separate hamburger nav utlity nav style separate from utility-nav.scss * reverting merge conflict fix 1 * reverting merge conflict fix 2 * fix search access icon in page view * fix lint errors * lint error fix * fix the hidden utility content height * correct target container for utility content * adjust vertical positioning of the menu button text * move back original styles belong to utility_nav.scss * correct class in utility item * set up open/close behaviors for wide/util nav bar 'log in to' * set up open/close behaviors for narrow/hamburger menu 'log in to * fix conflict between 'log in to' buttons * uncomment test style * set focus between menu button, hamburger menu container, jump to search button and search input * test edit * fix syntax error * merge hamburger and mix template and scss to minimize duplicate. * clean up duplicate * merge mainNavMixed.js to mainNavHamburger.js * fix width for log in to content * fix lint errors * lint error fix * fix positioning of the hamburger menu container * smooth open/close behavior of log in to content in wide version * adjust open/close behavior of log in to content in wide version * remove invalid attribute * remove duplicate markup * style log in to content in hamburger nav * fix error * fix errors * fix error * test edit * fix some lint errors in the existing code * remove test style * resolve conflicts between utilNav.js and mainNavHamburger.js * remove duplicate markup * fix conflicts between 2 utlity content displays * set container size for utility container in hamburger menu on load * hide utility nav content when sub menu in main nav is open * remove unnecessary aria-label from hamburger main nav * hide hamburger menu at resizing window in mix over 841 * Hide hamburger menu when window size is resized to over 840 while hamburger menu is open. * adjustment for Drupal output * test edit * add changelog for DP-17154 * remove box-shadow from utility nav item in hamburger menu * setting up to close sub mneu as opening the utility nav content * set up focus on the search box in the hamburger menu by clicking the search icon on the utility nav bar * clean up unnecessary tabindex and aria-label * fix typo * setting up closure with esc key * adjust focsus issue as menu open/close * fix tabindex at closing menu button * add bottom border to 'log in to...' content box * remove unnecessary line * test edit * animation fix with util nav content * separate utility nav in hamburger nav from utilNav.js * remove unnecessary lines for open/close util. content function copied from open/close sub menu function * add closeSubmenu at opening util content * modify susubmenu closing animation at opening util. nav content * add a condition to che ck if any open submenu to closeSubmenu() * test edit * slow down closing submenu speed * clean up comments * add changelog for DP-19337 * fix lint error * Resolve conflict. * put back nav bar padding change in DP-19335 * clean up comments * menu botton positioning * fix format * fix menu button label which is not working in patternlab/DP-17200-add-horizontal-nav-code-branch * expand close button to fill the blue bar * fix lint error * fix lint error * slow the log-in-to content open/close animation * set focus on the hamburger menu from the first focusable item in the menu container with shift-tab. * keyboard navigation setting focus test edit * circle back focus to the first top menu button from the last focusable element in the menu * add condition to check button or link on top menu * fix conflicts with null last submenu link * set up escape + focus behaviors * additional patterns for escape behavior * add changelog for DP-17155 * add changelog the PR number * cleanup after resolving merge conflicts * remove menu label text from span.ma__header__hamburger__menu-text in header-mixed.twig * merge conflict clean up 2 * merge conflicts clean up 3 * fix backstop errors * switch an item to check null * fix setting focus on body, not menu button on load * DP-19683 Adjust overlay position (#1152) * set overlay below the blue nav bar * add changelog for DP-19683 * remove a duplicate variable definition from cleaning up merge conflicts * fix backstop failures from rendering error * DP-19738 IE11 issues (#1157) * add polyfill for NodeList.prototype.forEach * fix esc key issue with IE11 * add condition to check null for result.display * add escape key definition of 'e.key === Esc' for IE11 support * add changelog for DP-19738 * DP-19782 flyout scrolling (#1160) * fix the bottom cut off in the flyout * set a fomula to calculate the height of the flyout * test edit * test edit2 * adding a height calculation formula to the blue nav bar with screen size less than 841px * test edit3 * Fixed narrow utility nav for tablet sizes - DP-19782 * remove note comment * clean up comments * Fixed menu button scrolling to top and set scroll to top to show alerts button on smaller screens - DP-19782 * Changed height check to not use height at page load - DP-19782 * Set up with correct positioning and animated scroll - DP-19782 * Added back old method - DP-19782 * Replaced else statement - DP-19782 * Fixed extra height - DP-19782 * Revert "Fixed extra height - DP-19782" This reverts commit 3b4d6ac. * Keep menu closing behavior on resize in - DP-19872 Co-authored-by: Tom Fleming <[email protected]> * DP-19866: Scroll issue fix (#1174) * DP-19866: Scroll issue fix * DP-19866: Scroll to menu for desktop * DP-19877: Height of blue global nav bar is not tall enough on small screens (#1179) * DP-19877: Global nav blue bar height 40px => 44px * DP-19877: Global nav blue bar height 40px => 44px * DP-19739 voiceover issues (#1166) * correct roles in main menu elements * disable ESC default behavior in Safari * fix a lint error * fix visibility of utility menu content to screen readers * fix lint error * set up down arrow navigation to narrow util nav content * adding uparrow navigation for narrow util content links * test edit * up arrow adjustment for index and current item mismatch * add up arrow navigation for util content links * add changelog for DP-19739 * move focus from the menu button to the menu container(=flyout) with tab (#1159) * move focus from the menu button to the menu container(=flyout) with tab * add changelog for DP-19783 * test edit * fix lint error * test edit 2 * test edit3 * tabbing fix for safari * remove test styles * DP-19870: Fix scroll issue with off screen menu button scrolling to the top before moving to correct location (#1175) * DP-19866: Scroll issue fix * DP-19866: Scroll to menu for desktop * DP-19870: Scroll issue fix on mobile devices * DP-19868: Search icon issue fox for Apple devices * DP-19867: Search icon issue fox for Android devices * DP-19889: Global nav scroll should stop at bottom and not close on its own * Swapped back in JS-only menu animation - DP-19870 * Modified offsetting to work with Desktop - DP-19870 * Fixed scroll jump from top issue - DP-19870 * Made search button selection smoother - DP-19870 * Removed faking Safari input to get keyboard to pop up - DP-19868 * small change - DP-19868 * Some more changes - DP-19868 * One more open menu change and console log output - DP-19868 * Updating reference screenshots Co-authored-by: Tom Fleming <[email protected]> Co-authored-by: Yukiko Gannett <[email protected]> * DP-19953 Style the log in to content in the hamburger menu (#1182) * style the log in to content in the hamburger menu * add changelog for DP-19953 * DP-19879 Adjust overlay position and timing (#1180) * DP-19866: Scroll issue fix * DP-19866: Scroll to menu for desktop * DP-19870: Scroll issue fix on mobile devices * DP-19868: Search icon issue fox for Apple devices * DP-19867: Search icon issue fox for Android devices * DP-19889: Global nav scroll should stop at bottom and not close on its own * Swapped back in JS-only menu animation - DP-19870 * Modified offsetting to work with Desktop - DP-19870 * Fixed scroll jump from top issue - DP-19870 * adjust overlay position and timing * add changelog for DP-19879 * Made search button selection smoother - DP-19870 * overlay position adjustment per device and browser * remove feature to adjust overlay positioning as alert accordinon opens/closes while the menu is open * udpate changelog * Updating reference screenshots Co-authored-by: abaghdasaryan <[email protected]> Co-authored-by: Tom Fleming <[email protected]> * DP-19889 the menu scroll issue in iphone (#1183) * fix js error and lint issues * fix the menu closing with vertical scroll in iphone * add clean up task on body at closing menu * add changelog for DP-19889 * DP-19984 Style adjustment for links in the flyout menu (#1184) * remove chevron from link and adjust vertical alignment of arrow icon on the last sub menu item * add changelog for DP-19984 * Removed touchend events to prevent observed open on scroll - DP-19878 (#1185) * Removed touchend events to prevent observed open on scroll - DP-19878 * Added changelog - DP-19878 * DP-19987: log in to menu width (#1186) * Fixed width issue with log in to menu - DP-19987 * Added changelog - DP-19987 * DP-20029: Fixed search button behavior caused by resize events on phones (#1187) * Fixed search button behavior caused by resize events on phones - DP-20029 * Added changelog - DP-20029 * DP-20039 fix Safari closing issue (#1189) * Removed CSS causing Safari to crash in iOS12 #believeitornot * Added changelog - DP-20039 * DP-20038 Alert position and Menu scroll (#1190) * lock the alert scrolled position when the menu opens and reltains it when the menu closes. * fix lint issue * set nav container height * clean up comments * add changelog for DP-20037 and DP-20038 * set width to body * DP-20055 fix Firefox overlay (#1192) * Fixed Firefox-specific JS that was causing overlay issues - DP-20055 * Added changelog - DP-20055 * DP-20054 S7 search button (#1191) * Set timeout higher for jump to search to work on Galaxy S7 - DP-20054 * Added changelog - DP-20054 * Added changelog - DP-20054 * DP-20085 Fixed sticky TOC for new global nav (#1194) * Fixed sticky TOC to work with non-sticky menu - DP-20085 * Added changelog - DP-20085 * DP-20080/20096 ios scrolling issue + hamburger menu js cleanup (#1196) * remove unused function * merge commonOpenMenuTasks() to openMenu() * ios menuoverlay offset adjustment * add notes * Removes a few setTimeout functions, changes window scroll to be the same for all browsers. * clean up test code and unused functions * format cleanup * remove unused function * add change log for DP-20080 and DP-20096 Co-authored-by: smurrayatwork <[email protected]> * DP-20092 Fix menu issues affecting COVID-19 unemployment page with new global nav (#1197) * Added bind for tabbing function body truncation - DP-20092 * Added changelog * DP-20091 Reorder z-index values for overlay components (#1198) * change z-index value for the feedback button * update z-index value for the navigation components to be consistent * update z-index values for the menu container and the overlay * clean up comments * adjust z-index variables for designated values * add changelog for DP-20091 * clean up comments * Update _fixed-feedback-button.scss * Clean up comments. * Removed iPhone-specific overlay JS - DP-20091 * adjust z-index for sticky nav * adjust sticky toc positioning in screen width 840 and less * add a condition to check null item for original mobile main nav * fix original mobile nav open/close function * set a condition to be specific for original mobile main nav * put back removed block for testing * set up specific height value for the menu container in iphone Co-authored-by: Tom Fleming <[email protected]> * DP-20163 Remove extra space between the search component and the main menu in the menu container (#1201) * remove exta space between the search box and the main nav in the menu container * add changelog for DP-20163 * DP-20096 timing functioin cleanup (#1202) * remove unused function * merge commonOpenMenuTasks() to openMenu() * ios menuoverlay offset adjustment * add notes * Removes a few setTimeout functions, changes window scroll to be the same for all browsers. * clean up test code and unused functions * format cleanup * remove unused function * add change log for DP-20080 and DP-20096 * DP-20096: Adds support for scrolling into view menu items in hambuger menu. * DP-20096: Fixes bug causing submenu to close when submenu item clicked. * add a no-alert rule for lockPage(). * remove test output code * move 'positioin: fixed;' to no alert rule * Fixes bug causing page to scroll when clicking submenu items on desktop. Co-authored-by: Yukiko Gannett <[email protected]> Co-authored-by: smurrayatwork <[email protected]> * DP-20176 Utility nav item container open/close state icon (#1205) * put back missing DP-20085 sticky TOC fix * fix util nav button state via keyboard navigation in the menu container * add changelog for DP-20176 * Update DP-20176.yml * DP-20181 Focus from the linked logo in the menu to the menu button (#1206) * fix focus order from the linked logo in the menu to menu button * add changelog for DP-20181 * DP-20090 menu search align (#1200) * Adjusted styling to align menu text and icon - DP-20090 * Second pass at menu icon centering - DP-20090 * Added changelog - DP-20090 * Address flex issues for iOS less than 11 - DP-20090 * adjusted class name - DP-20090 Co-authored-by: Yukiko Gannett <[email protected]> * DP-20201: Fix scroll issues noticed on iOS (#1210) * Fixed scroll issues noticed on iPads - DP-20201 * Added changelog - DP-20201 * DP-20119 Update the global nav in all page (#1213) * switch main navigation to new one * update home page samples * adjust z-index for sticky table header to make the menu button clickable * add changelog for DP-20119 * Updating reference screenshots with the new global nav * DP-20209 iOS scroll issue (#1211) * Fixed scroll issue for iOS and hopefully didn't break other devices - DP-20209 * Added changelog - DP-20209 * Revert "Added changelog - DP-20209" This reverts commit 6f4f29f. * Revert "Revert "Added changelog - DP-20209"" This reverts commit 4c55ad5. * Revert "Fixed scroll issue for iOS and hopefully didn't break other devices - DP-20209" This reverts commit 40dc92b. * Revert "Revert "Fixed scroll issue for iOS and hopefully didn't break other devices - DP-20209"" This reverts commit c9592a8. * Addressed issues with iPhone 7 crashes, getting menu height to show everything - DP-20209 * Changed offset height to nav - DP-20209 * fix for iPads - DP-20209 * Changed how some calculated variables are stored - DP-20209 * Fixed scrollTo issue with mainNavHamburger.js - DP-17200 Co-authored-by: Yukiko Gannett <[email protected]> Co-authored-by: Tom Fleming <[email protected]> Co-authored-by: smurrayatwork <[email protected]> * Update DP-19984.yml (#1215) Fix typo and indentation. * fix changelog format (#1217) * Update DP-19738.yml (#1218) * Update DP-20038.yml (#1219) * Changelog update and remove old changelog files Co-authored-by: Minghua Sun <[email protected]> Co-authored-by: Arthur Baghdasaryan <[email protected]> Co-authored-by: Tom Fleming <[email protected]> Co-authored-by: smurrayatwork <[email protected]>
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Changes global nav blue bar height form 40px into 44px
Related Issue / Ticket