Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

add mocks for evm signature functions #309

Merged
merged 2 commits into from
Nov 15, 2023
Merged

add mocks for evm signature functions #309

merged 2 commits into from
Nov 15, 2023

Conversation

peterjah
Copy link
Contributor

No description provided.

@sonarqubecloud SonarQubeCloud
Copy link

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 1 Code Smell

No Coverage information No Coverage information
0.0% 0.0% Duplication

Eitu33
Eitu33 approved these changes Nov 14, 2023
View reviewed changes
Copy link
Contributor

@Eitu33 Eitu33 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM but I'm just noticing now that we require raw public keys as input for validation but return them with the extra byte when executing a recovery, maybe we'd like to unify these behaviour?

@Ben-Rey Ben-Rey self-requested a review November 14, 2023 16:12
@peterjah peterjah merged commit fa3e295 into main Nov 15, 2023
5 checks passed
@peterjah peterjah deleted the evm_mocks branch November 15, 2023 10:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Eitu33 Eitu33 Eitu33 approved these changes

@Ben-Rey Ben-Rey Ben-Rey approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@peterjah @Ben-Rey @Eitu33 @massabot