Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

remove duplicate imports #232

Merged
merged 1 commit into from
Feb 18, 2023
Merged

remove duplicate imports #232

merged 1 commit into from
Feb 18, 2023

Conversation

josiahsrc
Copy link
Contributor

@josiahsrc josiahsrc commented Feb 15, 2023

We've seen some issues on our project indicating that this repo has duplicate React declarations. For instance, we're seeing this error:

[commonjs--resolver] Identifier 'React' has already been declared (2:10) in /usr/src/app/node_modules/react-resize-detector/build/index.esm.js
file: /usr/src/app/node_modules/react-resize-detector/build/index.esm.js:2:10
1: import*as React from'react';import {cloneElement,isValidElement,createRef,PureComponent,Component,forwardRef,useRef,useState,useEffect,useLayoutEffect}from'react';import {findDOMNode}from'react-dom';/******************************************************************************
2: Copyright (c) Microsoft Corporation.

I confirmed that these changes fix the above error and still functions as intended.

Copy link
Collaborator

@Semigradsky Semigradsky left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@MichaelWGibson
Copy link

I'm running into the same issue, any chance we could get this merged?

@snelsi
Copy link
Collaborator

snelsi commented Feb 17, 2023

@maslianok Please take a look when you have time

@maslianok maslianok merged commit fdf1243 into maslianok:master Feb 18, 2023
@maslianok
Copy link
Owner

@josiahsrc Thank you! merged

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants