Use useEffect for SSR, add ref.current to dependency array #139
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
whplh
changed the title
whplh
commented
Feb 14, 2021
| @@ -36,7 +38,7 @@ function useResizeDetector<RefType extends Element = Element>(props: FunctionPro | |||
| height: undefined | |||
| }); | |||
|
|
|||
| useLayoutEffect(() => { | |||
| useEnhancedEffect(() => { | |||
| if (isSSR()) { | |||
| return; | |||
There was a problem hiding this comment.
Just as a side note: If the hook would actually do something which depends on targetRef these changes would be problematic in some cases (because of const ref: MutableRefObject<null | RefType> = targetRef ?? localRef;)
maslianok
reviewed
Feb 16, 2021
| @@ -81,7 +81,7 @@ const CustomComponent = () => { | |||
| import { useResizeDetector } from 'react-resize-detector'; | |||
|
|
|||
| const CustomComponent = () => { | |||
| const targetRef = userRef(); | |||
| const targetRef = useRef(); | |||
|
Merged. Thanks for your work 👍 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Relates to #130 and #138
fix for #138 borrowed from (MIT-License)
Resources for #138: res1 and maybe res2