Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add a function to get the list of cards in the deck #56

Merged
merged 1 commit into from
Jul 15, 2023

Conversation

pjw5521
Copy link
Collaborator

@pjw5521 pjw5521 commented Jul 15, 2023

Issue Number

close: #55

Description

구현 내용 및 작업한 내용

  • add a function to get the list of cards in the deck
  • CardRepository is registered as a provider in DeckModule

To Reviewers

PR을 볼 때 주의깊게 봐야하거나 말하고 싶은 점

N/A

Checklist

PR 등록 전 확인한 것

  • PR 제목은 포맷과 내용 둘 다 알맞게 작성되었는가 (e.g., feat: 로그인 페이지 추가)
  • description에 PR에 대해 구체적으로 설명했는가

@pjw5521 pjw5521 merged commit 4737d6b into master Jul 15, 2023
@pjw5521 pjw5521 deleted the feature/get-cardlist branch July 15, 2023 10:31
@JonghunAn
Copy link
Member

@minidonut 형 이거 나중에 한번봐줘!

지원이가 DeckModule에 CardModule 의존성 주입안하고
DeckModule provider에 CardRepository를 넣었는데
어캐 정상동작하는지 모르겠어!!

CardModule에 CardRepository를 export처리하고
DeckModule -> CardModule (DI)하고 provider에는 CardRePository를 넣으면 안되는거 아닌가...??

@JonghunAn JonghunAn requested a review from saehun July 16, 2023 05:58
@saehun
Copy link
Contributor

saehun commented Jul 16, 2023

원래는 그렇게 해줘야하는게 맞는데 ㅋㅋㅋㅋㅋ 뭐, CardRepository 인스턴스가 그냥 두개 생긴거지 뭐

@JonghunAn
Copy link
Member

JonghunAn commented Jul 17, 2023

원래는 그렇게 해줘야하는게 맞는데 ㅋㅋㅋㅋㅋ 뭐, CardRepository 인스턴스가 그냥 두개 생긴거지 뭐

provider에 적용하면 다른모듈에서 해당 Module import 안하면 호출 못하는거 아니었어...? ㅇㅅㅇ

@pjw5521
Copy link
Collaborator Author

pjw5521 commented Jul 17, 2023

원래는 그렇게 해줘야하는게 맞는데 ㅋㅋㅋㅋㅋ 뭐, CardRepository 인스턴스가 그냥 두개 생긴거지 뭐

수정할게요...

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

feat: add a function to get the list of cards in the deck
3 participants