Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: 카드 플레이 화면 #33

Merged
merged 13 commits into from
Jul 16, 2023
Merged

feat: 카드 플레이 화면 #33

merged 13 commits into from
Jul 16, 2023

Conversation

poiu694
Copy link
Member

@poiu694 poiu694 commented Jul 12, 2023 •
edited
Loading

Issue Number

#32

Description

구현 내용 및 작업한 내용

  • 카드의 색과 내부 아이콘을 쉽게 바꿀 수 있게 한다
  • secondary 버튼
  • Flip

To Reviewers

PR을 볼 때 주의깊게 봐야하거나 말하고 싶은 점

  • 카드의 타입을 만들었습니다. (flower, sprout, nail, plug, swallow, clover, tulnip, feather)
image image
  • 아직 작업중입니다!

Checklist

PR 등록 전 확인한 것

  • PR 제목은 포맷과 내용 둘 다 알맞게 작성되었는가 (e.g., feat: 로그인 페이지 추가)
  • description에 PR에 대해 구체적으로 설명했는가

@poiu694 poiu694 self-assigned this Jul 12, 2023
@poiu694 poiu694 marked this pull request as draft July 12, 2023 23:19
@poiu694 poiu694 linked an issue Jul 12, 2023 that may be closed by this pull request
feat: 플레이 페이지 #32
Closed
3 tasks
@poiu694 poiu694 marked this pull request as ready for review July 15, 2023 07:29
@poiu694 poiu694 changed the title feat: 카드 플레이 화면 [WIP] feat: 카드 플레이 화면 Jul 15, 2023
yungjurick
yungjurick approved these changes Jul 15, 2023
View reviewed changes
Copy link
Collaborator

@yungjurick yungjurick left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

고생했어~~~

swimjiy
swimjiy approved these changes Jul 15, 2023
View reviewed changes
Copy link
Member

@swimjiy swimjiy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

굿굿! 고생했어~~

@swimjiy swimjiy mentioned this pull request Jul 15, 2023
Merged
7 tasks
@poiu694 poiu694 merged commit 0fe9fc0 into master Jul 16, 2023
@poiu694 poiu694 deleted the feature/card-play branch July 16, 2023 01:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@yungjurick yungjurick yungjurick approved these changes

@swimjiy swimjiy swimjiy approved these changes

Assignees

@poiu694 poiu694

Labels
frontend 🍓
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

feat: 플레이 페이지
3 participants
@poiu694 @yungjurick @swimjiy