Feat: add Toggle Button(set up tailwind in monorepo) #15
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
poiu694
force-pushed
the
feature/toggle-button
branch
from
ff7c074
to
b07bfea
Compare
yungjurick
approved these changes
Jun 18, 2023
poiu694
force-pushed
the
feature/toggle-button
branch
from
d2ac3ec
to
3f256ea
Compare
swimjiy
approved these changes
Jun 18, 2023
|
ffcc19a 린트 확인했고 머지하겠습니당~ |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related Issue #14
Toggle Button을 생성했습니다.
workspace가
service-frontend,ui로 나누어져있어,tailwind.config.js를 두 개를 같이 수정해야 했어서tailwind-configworkspace를 통해 관리 포인트를 하나로 줄였습니다.기존
service-frontend에서ui내 컴포넌트를 가져왔을 경우transpile이 되어있지 않아 문제가 있던 부분을 해결했습니다.color token이 적용되지 않아서 임시로 헥사값을 그대로 넣었습니다!
컬러 디자인 시스템 적용하고 올릴까 했는데, monorepo 설정으로 인한 오류를 겪게될 것 같아서 미리 올립니당
Preview
In service
Storybook
Animation
크롬에서는 나쁘지 않게 보이는 것 같은데..>! 캡쳐하니까 묘하게 끊겨보이네요