Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: apply front QA #141

Merged
merged 3 commits into from
Aug 12, 2023
Merged

fix: apply front QA #141

merged 3 commits into from
Aug 12, 2023

Conversation

swimjiy
Copy link
Member

@swimjiy swimjiy commented Aug 12, 2023 •
edited
Loading

Issue Number

close: #

Description

구현 내용 및 작업한 내용

  • /complete 페이지의 스타일 조정
  • /confirm-detail, /play 페이지에 API로 요청받은 타이틀, totalCount 적용
  • metaData에 metadataBase 추가 (by @poiu694)

To Reviewers

PR을 볼 때 주의깊게 봐야하거나 말하고 싶은 점

  • 전달 사항 1
  • 전달 사항 2

Checklist

PR 등록 전 확인한 것

  • PR 제목은 포맷과 내용 둘 다 알맞게 작성되었는가 (e.g., feat: 로그인 페이지 추가)
  • description에 PR에 대해 구체적으로 설명했는가

@swimjiy swimjiy self-assigned this Aug 12, 2023
poiu694
poiu694 approved these changes Aug 12, 2023
View reviewed changes
Copy link
Member

@poiu694 poiu694 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

슛!

@swimjiy swimjiy merged commit 0cd35e4 into master Aug 12, 2023
@swimjiy swimjiy deleted the fix/qa branch August 12, 2023 04:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@poiu694 poiu694 poiu694 approved these changes

@yungjurick yungjurick Awaiting requested review from yungjurick

Assignees

@swimjiy swimjiy

@poiu694 poiu694

Labels
frontend 🍓
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@swimjiy @poiu694