Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: implement api call on main api, add 404 and loading page #115

Merged
merged 3 commits into from
Aug 6, 2023

Conversation

swimjiy
Copy link
Member

@swimjiy swimjiy commented Aug 6, 2023

Issue Number

close: #112

Description

구현 내용 및 작업한 내용

  • 메인 페이지 API 연동
  • 404, Loading 페이지 추가

Group 1

To Reviewers

PR을 볼 때 주의깊게 봐야하거나 말하고 싶은 점

  • Loading 페이지는 임시로 만들었습니다.
  • API 정상 동작하는지, react-query 연동 잘 되었는지 확인 부탁합니다~

Checklist

PR 등록 전 확인한 것

  • PR 제목은 포맷과 내용 둘 다 알맞게 작성되었는가 (e.g., feat: 로그인 페이지 추가)
  • description에 PR에 대해 구체적으로 설명했는가

@swimjiy swimjiy self-assigned this Aug 6, 2023
Copy link
Collaborator

@yungjurick yungjurick left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM~

Copy link
Member

@poiu694 poiu694 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍👍

@swimjiy swimjiy merged commit 68e2b8a into master Aug 6, 2023
@swimjiy swimjiy deleted the feat/add-main-api branch August 6, 2023 07:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

feat: 메인 페이지 API 연동
3 participants