Add getting study details api #64
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
SeongYunKim
approved these changes
Jun 19, 2023
| fun getDetails(studyId: Long): StudyDetailsResponse { | ||
| val study = studyService.findById(studyId) | ||
| val moit = moitService.findById(study.moitId) | ||
| val firstAttendanceUserNickname = study.firstAttendanceUserId?.let(userService::findByIdOrNull)?.nickname |
There was a problem hiding this comment.
여기서는 user 가 반드시 있어야 하는 상황같은데, userService::findById 를 사용해도 괜찮지 않을까요?
There was a problem hiding this comment.
firstattendanceUser 는 nullable 한거 아닌가요?
| fun of( | ||
| moit: Moit, | ||
| study: Study, | ||
| firstAttendanceUserNickname: String? |
There was a problem hiding this comment.
nickname 말고 첫 출석자의 다른 정보가 추후 DTO 에 추가될 때를 생각해보면, 인자로 firstAttendanceUser 만 User? 타입으로 받고 DTO firstAttendanceUserNickname 에 nickname 할당해 주는 것도 괜찮을 것 같습니다..!
xonmin
force-pushed
the
feature/fine-list
branch
from
6a387ce to
cd31e40
Compare
|
rebase 한 번 부탁드립니다! |
mkSpace
force-pushed
the
feature/study-details
branch
from
4b99075 to
a4d0f55
Compare
mkSpace
force-pushed
the
feature/study-details
branch
from
a4d0f55 to
3589fa9
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
스터디 상세 조회 API 입니다
API 1번에 해당하는 내용입니다
#61 PR 머지 이후 머지할 예정입니다