Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Full review of KNet Streams SDK classes #422

Merged
merged 28 commits into from
Feb 22, 2024
Merged

Full review of KNet Streams SDK classes #422

merged 28 commits into from
Feb 22, 2024

Conversation

masesdevelopers
Copy link
Contributor

@masesdevelopers masesdevelopers commented Feb 21, 2024 •
edited
Loading

Description

This PR updates the classes of:

  • KNetConsumer/KNetProducer: supporting classes align the name to the JVM counter-part
  • KNet Streams SDK:
    • adds JVM type counter-part
    • renames the classes to align to the JVM counter-part

Both #420 and this PR introduce breaking changes

Related Issue

fix #327

Motivation and Context

How Has This Been Tested?

Screenshots (if appropriate):

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

Checklist:

  • My code follows the code style of this project.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have read the CONTRIBUTING document.
  • I have added tests to cover my changes.
  • All new and existing tests passed.

@masesdevelopers
Added other classes to KNet Streams SDK
8a6dfa4
@masesdevelopers
Temp update
5564bd2
@masesdevelopers
Temporary generation of classes with new JNetReflector: only for test
7429181
@masesdevelopers
Code alignment to latest generated classes which uses Java.Lang.String
1b5addd
@masesdevelopers
Temp to be reopened
88fbf02
@masesdevelopers
Update IKNetDeserializer, IKNetSerializer, IKNetSerDes to manage JVM …
951ebac 
…type
@masesdevelopers
Update tests
b689ab5
@masesdevelopers
Merge remote-tracking branch 'upstream/master' into 416-avoid-use-of-…
a8192b6 
…string-systemstring-and-prefer-javalangstring-in-reflected-classes
@masesdevelopers
Merge branch '327-improve-kafka-streams-with-some-specific-knet-class…
17e73f3 
…es-10' of https://github.com/masesdevelopers/KafkaBridge into 327-improve-kafka-streams-with-some-specific-knet-classes-10
@masesdevelopers
Update to JNet 2.3.0 and bump Google.Protobuf version
b64dad7
@masesdevelopers
Documentation fix
f1c187c
@masesdevelopers
Avoid release trigger when description is edited
6b19514
@masesdevelopers
Merge branch '416-avoid-use-of-string-systemstring-and-prefer-javalan…
1224e40 
…gstring-in-reflected-classes' into 327-improve-kafka-streams-with-some-specific-knet-classes-10
@masesdevelopers
General review of classes with JVM type added beside .NET type
5d5d8de
@masesdevelopers
Reviewed how the IGenericSerDesFactory is shared across the classes
c91dad4
@masesdevelopers
Added new serialization builder
6966f94
@masesdevelopers
Merge remote-tracking branch 'upstream/master' into 327-improve-kafka…
714bfe9 
…-streams-with-some-specific-knet-classes-10
@masesdevelopers
Rename step 1
8e44b0e
@masesdevelopers
Rename step 2
8bc6d04
@masesdevelopers
Rename all classes to align the name to the same of the JVM version
1b228f3
@masesdevelopers
Update test programs
8ce1cf2
@masesdevelopers masesdevelopers added documentation Improvements or additions to documentation enhancement New feature or request KNet KNet related issue KNetTemplates KNet Templates related issue KNetSerDes KNetSerDes related issue .NET Pull requests that update .net code labels Feb 21, 2024
@masesdevelopers masesdevelopers self-assigned this Feb 21, 2024
@masesdevelopers masesdevelopers merged commit 07417e1 into masesgroup:master Feb 22, 2024
6 checks passed
@masesdevelopers masesdevelopers deleted the 327-improve-kafka-streams-with-some-specific-knet-classes-10 branch February 22, 2024 01:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@masesdevelopers masesdevelopers

Labels
documentation Improvements or additions to documentation enhancement New feature or request KNet KNet related issue KNetSerDes KNetSerDes related issue KNetTemplates KNet Templates related issue .NET Pull requests that update .net code
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Improve Kafka Streams with some specific KNet classes
1 participant
@masesdevelopers