Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Improved DeserializeWithHeaders when the input is null #247

Merged
merged 1 commit into from
Oct 5, 2023
Merged

Improved DeserializeWithHeaders when the input is null #247

merged 1 commit into from
Oct 5, 2023

Conversation

masesdevelopers
Copy link
Contributor

Description

If the input is null the return value is the default of the expected type to be deserialized

Related Issue

Closed #244

Motivation and Context

How Has This Been Tested?

Local tests

Screenshots (if appropriate):

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

Checklist:

  • My code follows the code style of this project.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have read the CONTRIBUTING document.
  • I have added tests to cover my changes.
  • All new and existing tests passed.

@masesdevelopers masesdevelopers added bug Something isn't working KNetSerDes KNetSerDes related issue labels Oct 5, 2023
@masesdevelopers masesdevelopers self-assigned this Oct 5, 2023
@masesdevelopers masesdevelopers merged commit c555eec into masesgroup:master Oct 5, 2023
7 checks passed
@masesdevelopers masesdevelopers deleted the 244-systemtextjsonjsonreaderexception-raised-with-null-inputs branch October 5, 2023 13:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mariomastrodicasa mariomastrodicasa mariomastrodicasa approved these changes

Assignees

@masesdevelopers masesdevelopers

Labels
bug Something isn't working KNetSerDes KNetSerDes related issue
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

System.Text.Json.JsonReaderException raised with null inputs
2 participants
@masesdevelopers @mariomastrodicasa