#245: cast fix using JVMBridgeBase.Wraps
#246
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
masesdevelopers
added
bug
…rk-right-without-jvmbridgebasewraps
mariomastrodicasa
approved these changes
Oct 5, 2023
masesdevelopers
changed the title
JVMBridgeBase.WrapsJVMBridgeBase.Wraps
masesdevelopers
deleted the
245-the-object-cast-does-not-work-right-without-jvmbridgebasewraps
branch
| @@ -290,7 +290,7 @@ public static float DeserializeFloat(string topic, byte[] data) | |||
| /// </summary> | |||
| public static int DeserializeInt(string topic, byte[] data) | |||
| { | |||
| return (int)_IntDeserializer.Deserialize(topic, data); | |||
| return JVMBridgeBase.Wraps<Java.Lang.Integer>(_IntDeserializer.Deserialize(topic, data) as IJavaObject); | |||
There was a problem hiding this comment.
Running the tests related to KNetCompactedReplicator seems the result of Deserialize is not always a Java object. I don't understand why but the result is an int instead of java.lang.Integer even if the Java signature is public Integer deserialize(String topic, byte[] data). Maybe a better implementation needs a check against IJavaObject.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Update cast to Java type with
JVMBridgeBase.WrapsRelated Issue
Closed #245
Motivation and Context
How Has This Been Tested?
Local test on returned object from JVM
Screenshots (if appropriate):
Types of changes
Checklist: