Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Removed string from definition of KNet generic types #64

Conversation

masesdevelopers
Copy link
Collaborator

Description

Removed the use of <string, string> definition into KNet types moving to the .NET typed classes.

Related Issue

Closed #59

Motivation and Context

How Has This Been Tested?

Tested with available tests

Screenshots (if appropriate):

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

Checklist:

  • My code follows the code style of this project.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have read the CONTRIBUTING document.
  • I have added tests to cover my changes.
  • All new and existing tests passed.

@masesdevelopers masesdevelopers added the enhancement New feature or request label Oct 1, 2023
@masesdevelopers masesdevelopers self-assigned this Oct 1, 2023
@masesdevelopers masesdevelopers merged commit 295a9dd into masesgroup:master Oct 1, 2023
5 checks passed
@masesdevelopers masesdevelopers deleted the 59-remove-string-from-definition-of-kafka-generic-types branch October 1, 2023 12:59
@mariomastrodicasa
Copy link

Testing the modifications introduced from this PR many times the test raises a java.lang.NullPointerException at

var future = _kafkaProducer?.Send(new KNetProducerRecord<TKey, KNetEntityTypeData<TKey>>(record.AssociatedTopicName, 0, record.Key, record.Value!));

The exception is raised after an uncertain number of iterations over the input of
public IEnumerable<Future<RecordMetadata>> Commit(IEnumerable<IKafkaRowBag> records)

The remote callstack reports:

org.apache.kafka.clients.producer.KafkaProducer.doSend(KafkaProducer.java:996)
org.apache.kafka.clients.producer.KafkaProducer.send(KafkaProducer.java:962)
org.apache.kafka.clients.producer.KafkaProducer.send(KafkaProducer.java:847)

@mariomastrodicasa
Copy link

Testing the modification introduced from this PR seems the speed of LINQ query is very poor; the following code

context.Posts.Single(b => b.BlogId == 2)

takes more or less 16 seconds to be executed as reported from the following output:
Elapsed context.Posts.Single(b => b.BlogId == 2) 16299 ms. Result is PostId: 2 Title: title Content: 2 BlogId: 2

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Remove string from definition of Kafka generic types
2 participants