Skip to content

Commit

Permalink
Removed other warning messages, plus an unused class
Browse files Browse the repository at this point in the history
  • Loading branch information
masesdevelopers committed Oct 21, 2023
1 parent 088e962 commit ff459ea
Show file tree
Hide file tree
Showing 8 changed files with 61 additions and 90 deletions.
Original file line number Diff line number Diff line change
Expand Up @@ -175,7 +175,7 @@ public virtual KafkaOptionsExtension WithUseNameMatching(bool useNameMatching =

return clone;
}
/// <inheritdoc cref="KafkaDbContext.DbName"/>
/// <inheritdoc cref="KafkaDbContext.DatabaseName"/>
public virtual KafkaOptionsExtension WithDatabaseName(string databaseName)
{
var clone = Clone();
Expand Down
4 changes: 2 additions & 2 deletions src/net/KEFCore/Query/Internal/AnonymousObject.cs
Original file line number Diff line number Diff line change
Expand Up @@ -45,11 +45,11 @@ public AnonymousObject(object[] values)

public static bool operator !=(AnonymousObject x, AnonymousObject y)
=> !x.Equals(y);

/// <inheritdoc/>
public override bool Equals(object? obj)
=> obj is not null && (obj is AnonymousObject anonymousObject
&& _values.SequenceEqual(anonymousObject._values));

/// <inheritdoc/>
public override int GetHashCode()
{
var hash = new HashCode();
Expand Down
10 changes: 8 additions & 2 deletions src/net/KEFCore/Query/Internal/KafkaQueryContext.cs
Original file line number Diff line number Diff line change
Expand Up @@ -29,12 +29,18 @@ namespace MASES.EntityFrameworkCore.KNet.Query.Internal;
public class KafkaQueryContext : QueryContext
{
private readonly IKafkaCluster _cluster;

/// <summary>
/// Retrieve <see cref="ValueBuffer"/> for the specified <see cref="IEntityType"/>
/// </summary>
/// <param name="entityType"></param>
/// <returns></returns>
public virtual IEnumerable<ValueBuffer> GetValueBuffers(IEntityType entityType)
{
return _cluster.GetValueBuffers(entityType);
}

/// <summary>
/// Default initializer
/// </summary>
public KafkaQueryContext(QueryContextDependencies dependencies, IKafkaCluster cluster)
: base(dependencies)
{
Expand Down
4 changes: 3 additions & 1 deletion src/net/KEFCore/Query/Internal/KafkaQueryContextFactory.cs
Original file line number Diff line number Diff line change
Expand Up @@ -28,7 +28,9 @@ namespace MASES.EntityFrameworkCore.KNet.Query.Internal;
public class KafkaQueryContextFactory : IQueryContextFactory
{
private readonly IKafkaCluster _cluster;

/// <summary>
/// Default initializer
/// </summary>
public KafkaQueryContextFactory(
QueryContextDependencies dependencies,
IKafkaClusterCache clusterCache,
Expand Down
6 changes: 3 additions & 3 deletions src/net/KEFCore/Query/Internal/KafkaQueryExpression.cs
Original file line number Diff line number Diff line change
Expand Up @@ -639,7 +639,7 @@ public virtual EntityShaperExpression AddNavigationToWeakEntityType(

return entityShaper;
}

/// <inheritdoc/>
public virtual ShapedQueryExpression Clone(Expression shaperExpression)
{
var clonedKafkaQueryExpression = Clone();
Expand Down Expand Up @@ -667,10 +667,10 @@ public virtual Expression GetSingleScalarProjection()

public virtual void ConvertToSingleResult(MethodInfo methodInfo)
=> _singleResultMethodInfo = methodInfo;

/// <inheritdoc/>
public override Type Type
=> typeof(IEnumerable<ValueBuffer>);

/// <inheritdoc/>
public sealed override ExpressionType NodeType
=> ExpressionType.Extension;

Expand Down
Loading

0 comments on commit ff459ea

Please sign in to comment.