Update packages to latest version and other minor fixes (#141)

masesgroup · Oct 25, 2023 · 7d1355a · 7d1355a
1 parent 97f5379
commit 7d1355a
Show file tree

Hide file tree

Showing 5 changed files with 14 additions and 9 deletions.
diff --git a/src/net/KEFCore.SerDes.Avro/AvroKEFCoreSerDes.cs b/src/net/KEFCore.SerDes.Avro/AvroKEFCoreSerDes.cs
@@ -81,7 +81,11 @@ public override byte[] SerializeWithHeaders(string topic, Headers headers, T dat
                 using MemoryStream memStream = new();
                 BinaryEncoder encoder = new(memStream);
                 var container = new AvroKeyContainer();
-                container.PrimaryKey = new List<object>(data as object[]);
+                if (data is object[] dataArray)
+                {
+                    container.PrimaryKey = new List<object>(dataArray);
+                }
+                else throw new InvalidDataException($"Cannot manage inputs different from object[], input is {data?.GetType()}");
                 SpecificWriter.Write(container, encoder);
                 return memStream.ToArray();
             }

diff --git a/src/net/KEFCore.SerDes/KEFCore.SerDes.csproj b/src/net/KEFCore.SerDes/KEFCore.SerDes.csproj
@@ -41,8 +41,8 @@
 	</ItemGroup>
 
 	<ItemGroup>
-		<PackageReference Include="Microsoft.EntityFrameworkCore" Version="6.0.23" PrivateAssets="none" Condition="'$(TargetFramework)' == 'net6.0'"/>
-		<PackageReference Include="Microsoft.EntityFrameworkCore" Version="7.0.12" PrivateAssets="none" Condition="'$(TargetFramework)' == 'net7.0'"/>
+		<PackageReference Include="Microsoft.EntityFrameworkCore" Version="6.0.24" PrivateAssets="none" Condition="'$(TargetFramework)' == 'net6.0'" />
+		<PackageReference Include="Microsoft.EntityFrameworkCore" Version="7.0.13" PrivateAssets="none" Condition="'$(TargetFramework)' == 'net7.0'" />
 		<PackageReference Include="MASES.KNet" Version="2.2.0">
 			<IncludeAssets>All</IncludeAssets>
 			<PrivateAssets>None</PrivateAssets>

diff --git a/src/net/KEFCore.SerDes/KEFCoreSerDes.Helpers.cs b/src/net/KEFCore.SerDes/KEFCoreSerDes.Helpers.cs
@@ -189,6 +189,7 @@ public static object FromRecord(ConsumerRecord<byte[], byte[]> record, bool thro
     /// <param name="valueContainer">Expected ValueContainer <see cref="Type"/></param>
     /// <param name="keySerializer">Key serializer to be used</param>
     /// <param name="valueContainerSerializer">ValueContainer serializer to be used</param>
+    /// <param name="topic">The Apache Kafka topic the data is coming from</param>
     /// <param name="recordValue">The Apache Kafka record value containing the information</param>
     /// <param name="recordKey">The Apache Kafka record key containing the information</param>
     /// <param name="throwUnmatch">Throws exceptions if there is unmatch in data retrieve, e.g. a property not available or a not settable</param>

diff --git a/src/net/KEFCore.SerDes/LocalEntityExtractor.cs b/src/net/KEFCore.SerDes/LocalEntityExtractor.cs
@@ -33,8 +33,8 @@ class LocalEntityExtractor<TKey, TValueContainer, TKeySerializer, TValueSerializ
     where TKeySerializer : class, new()
     where TValueSerializer : class, new()
 {
-    private readonly IKNetSerDes<TKey> _keySerdes;
-    private readonly IKNetSerDes<TValueContainer> _valueSerdes;
+    private readonly IKNetSerDes<TKey>? _keySerdes;
+    private readonly IKNetSerDes<TValueContainer>? _valueSerdes;
 
     public LocalEntityExtractor()
     {

diff --git a/test/Common/Common.props b/test/Common/Common.props
@@ -12,10 +12,10 @@
 	</ItemGroup>
 
 	<ItemGroup>
-		<PackageReference Include="Microsoft.EntityFrameworkCore" Version="6.0.23" PrivateAssets="none" Condition="'$(TargetFramework)' == 'net6.0'"/>
-		<PackageReference Include="Microsoft.EntityFrameworkCore.InMemory" Version="6.0.23" Condition="'$(TargetFramework)' == 'net6.0'"/>
-		<PackageReference Include="Microsoft.EntityFrameworkCore" Version="7.0.12" PrivateAssets="none" Condition="'$(TargetFramework)' == 'net7.0'"/>
-		<PackageReference Include="Microsoft.EntityFrameworkCore.InMemory" Version="7.0.12" Condition="'$(TargetFramework)' == 'net7.0'"/>
+		<PackageReference Include="Microsoft.EntityFrameworkCore" Version="6.0.24" PrivateAssets="none" Condition="'$(TargetFramework)' == 'net6.0'"/>
+		<PackageReference Include="Microsoft.EntityFrameworkCore.InMemory" Version="6.0.24" Condition="'$(TargetFramework)' == 'net6.0'"/>
+		<PackageReference Include="Microsoft.EntityFrameworkCore" Version="7.0.13" PrivateAssets="none" Condition="'$(TargetFramework)' == 'net7.0'"/>
+		<PackageReference Include="Microsoft.EntityFrameworkCore.InMemory" Version="7.0.13" Condition="'$(TargetFramework)' == 'net7.0'"/>
 		<ProjectReference Include="..\..\src\net\KEFCore\KEFCore.csproj" />
 		<ProjectReference Include="..\..\src\net\KEFCore.SerDes.Avro\KEFCore.SerDes.Avro.csproj" />