Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Moved command-line arg into environment variable #334

Merged
merged 1 commit into from
Jan 27, 2024
Merged

Moved command-line arg into environment variable #334

merged 1 commit into from
Jan 27, 2024

Conversation

masesdevelopers
Copy link
Contributor

Description

The location of JVM can be overridden if needed

Related Issue

closed #333

Motivation and Context

How Has This Been Tested?

Screenshots (if appropriate):

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

Checklist:

  • My code follows the code style of this project.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have read the CONTRIBUTING document.
  • I have added tests to cover my changes.
  • All new and existing tests passed.

@masesdevelopers masesdevelopers added bug Something isn't working enhancement New feature or request Docker Docker images related issue labels Jan 27, 2024
@masesdevelopers masesdevelopers mentioned this pull request Jan 27, 2024
Merged
9 tasks
@masesdevelopers masesdevelopers merged commit 52f7917 into masesgroup:master Jan 27, 2024
7 checks passed
@masesdevelopers masesdevelopers deleted the 333-waiting-330-enters-in-master-branch-update-the-following-line-because-it-is-a-typo branch January 27, 2024 15:41
masesdevelopers added a commit to masesgroup/KNet that referenced this pull request Jan 27, 2024
@masesdevelopers
Apply this change related to masesgroup/JNet#334 (#390)
2c73f27
masesdevelopers added a commit to masesgroup/KNet that referenced this pull request Jan 27, 2024
@masesdevelopers
Revert "Apply this change related to masesgroup/JNet#334"
c9c8df1
masesdevelopers added a commit to masesgroup/KNet that referenced this pull request May 15, 2024
@masesdevelopers
Update Docker and NuGet Tools to .NET 8 (#384)
6aa6784 
* Update Docker to .NET 8

* Update JRE version and target compilation

* Update tools

* Retargeting KNetPS

* masesgroup/JNet#334 moves JVM path into environment variable, so it is no more needed it in command-line

* #382 (comment): update Dockerfile(s)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
bug Something isn't working Docker Docker images related issue enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Waiting #330 enters in master branch, update the following line because it is a typo
1 participant
@masesdevelopers