Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Upgrade Docker images and NuGet Tools to .NET 8 #329

Closed
masesdevelopers opened this issue Jan 26, 2024 · 7 comments · Fixed by #330, #474 or #505
Closed

Upgrade Docker images and NuGet Tools to .NET 8 #329

masesdevelopers opened this issue Jan 26, 2024 · 7 comments · Fixed by #330, #474 or #505
Assignees
@masesdevelopers
Labels
Docker Docker images related issue enhancement New feature or request

Comments

@masesdevelopers
Copy link
Contributor

masesdevelopers commented Jan 26, 2024 •
edited
Loading

Is your feature request related to a problem? Please describe.
Till now Docker images and NuGet Tools use .NET 6, try to upgrade to the latest .NET version or duplicate it

Describe the solution you'd like
Upgrade projects and move Docker image to .NET 8 using latest Microsoft images.

Describe alternatives you've considered
N/A

Additional context
Verify if this is possible because in an old update to .NET 7 something was wrong in Microsoft image
@masesdevelopers masesdevelopers added enhancement New feature or request Docker Docker images related issue labels Jan 26, 2024
@masesdevelopers masesdevelopers self-assigned this Jan 26, 2024
This was referenced Jan 26, 2024
Closed
Merged
@masesdevelopers masesdevelopers changed the title Upgrade Docker images to .NET 8 Upgrade Docker images and NuGet Tools to .NET 8 Jan 26, 2024
@masesdevelopers
Copy link
Contributor Author

The PR #330 contains PowerShell changes on .NET target version, but PowerShell 7 targets .NET 6:

  • wait PowerShell upgrade or
  • remove PowerShell updates fro the PR

@masesdevelopers
Copy link
Contributor Author

masesdevelopers commented Jan 27, 2024 •
edited
Loading

The PR #330 contains PowerShell changes on .NET target version, but PowerShell 7 targets .NET 6:

* wait PowerShell upgrade or

* remove PowerShell updates fro the PR

Latest version (7.4.1) works with .NET 8, so updating PS manifests it is enough

masesdevelopers added a commit to masesdevelopers/JNet that referenced this issue Jan 27, 2024
@masesdevelopers
masesgroup#329 (comment): changed minimum version
89e1f2d
@masesdevelopers
Copy link
Contributor Author

Push Docker images to Docker Hub too

@masesdevelopers masesdevelopers mentioned this issue Jan 29, 2024
Closed
@masesdevelopers
Copy link
Contributor Author

Docker scout reports some vulnerabilities should be solved:
image
Meanwhile the base image shall be changed to avoid the usage of the Debian OS. See https://mcr.microsoft.com/en-us/product/dotnet/runtime/tags and check the right variant to use; or surf https://github.com/dotnet/dotnet-docker/blob/main/documentation/ubuntu-chiseled.md for other info.

This was referenced Mar 13, 2024
Closed
Closed
masesdevelopers added a commit that referenced this issue May 14, 2024
@masesdevelopers
Update Docker and NuGet Tools to .NET 8 (#330)
bcdc569 
* Update Docker to .NET 8

* Update tools target version

* Upgrade PowerShell

* Move JVMPath in environment variables to avoid it in command-line

* #329 (comment): changed minimum version
@masesdevelopers
Copy link
Contributor Author

When running buildx, it fails on a cross-architecture build

@masesdevelopers
Copy link
Contributor Author

Solved with 63eff5f using information from NuGet/Home#12227 (comment)

@masesdevelopers
Copy link
Contributor Author

masesdevelopers commented Jun 27, 2024 •
edited
Loading

The line

JNet/src/container/Dockerfile.linux

Line 21 in d0ea1ee

ENV JCOBRIDGE_JVMPath=/usr/lib/jvm/java-17-openjdk-amd64/lib/server/libjvm.so
is wrong and depends only on amd64 while the image is built even for arm64 as reported in

JNet/.github/workflows/docker.yaml

Line 80 in d0ea1ee

platforms: linux/amd64,linux/arm64

@masesdevelopers masesdevelopers mentioned this issue Jun 28, 2024
Merged
9 tasks
@masesdevelopers masesdevelopers mentioned this issue Jul 31, 2024
Merged
9 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@masesdevelopers masesdevelopers

Labels
Docker Docker images related issue enhancement New feature or request
Projects
None yet
Milestone
No milestone
1 participant
@masesdevelopers