-
-
Notifications
You must be signed in to change notification settings - Fork 152
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
tomplusplus fails to compile with msvc 2017 #55
Comments
I'm not sure I consider this a bug, to be honest. VS2017's support for C++17 was something of a broken mess. Having said that, I guess these are pretty easy to work around. Thanks for letting me know. |
I've hit another bug...
and there's a clang-cl bug with detecting exceptions |
I know 2017 might not be a priority, but it's the last version with Express available (free enterprise use) |
Ah, that's easy fixed. It doesn't really make sense for that code to be marked
Yeh. I should probably simplify the way that's done anyway, since doing it per-compiler is not overly robust (since compilers all like to pretend to be each other anyways).
Be that as it may, I'm not going to jump through too many hoops to support it. I'm happy to make basic fixes like this, but consider VS2017 generally unsupported if much larger changes need to be made. |
@sobczyk I've just pushed fixes for the additional issues you ran into. |
Environment
Compiler:
MSVC2017
C++ standard mode (e.g. 17, 20, 'latest'):
c++17
Target arch (e.g. x64):
x64
Library configuration overrides:
Relevant compilation flags:
/permissive-
Describe the bug
bug 1
__has_cpp_attribute
is a c++20 featurein toml_preprocessor.h there is no check for this
bug 2
cast operators in array_iterator and table_iterator are not liked by msvc, because of
[[nodiscard]]
see https://godbolt.org/z/Kvdrd3
the problem is fixed in 19.20 (
_MSC_VER >= 1920
)The text was updated successfully, but these errors were encountered: