-
-
Notifications
You must be signed in to change notification settings - Fork 143
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
add currentOrientation(), a new example using hooks & upgrade all examples to expo v38 #83
base: master
Are you sure you want to change the base?
Conversation
Encapsulate the changes inspired by marudy#70
One note: in each of the examples' To engage with this version, you can follow these steps:
Now you are ready to run any of the examples. Let's try the new Hook-based one:
|
If not obvious (it is quite a large PR), the likely controversial parts of this are:
|
Can I use your fork in a production? |
It is warranted for its full price 🙂 I am using it in production. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Would you mind accepting this?
@gregfenton you could as well add hook support to currentOrientation, I can help if you'd like |
In trying to get a hooks example going, I ended up doing a fair amount of work I hope others might benefit from:
index.js
to support boththis
and auseState()
set functioncurrentOrientation()
useState
&useEffect
stylized-components
- as of v5 it requires units to be specified on many styles