Updated ssl support to work with tsl #8
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Please merge :) |
martynsmith
added a commit
that referenced
this pull request
Apr 29, 2011
Updated ssl support to work with tsl
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hey,
Couldn't get your library to work over ssl with a fresh install of node. Ended up implementing a connection strategy using the new tsl api and instead of rolling my own irc class, i figured i'd just update yours as it seems to be the best one out there.
Anyways, all i did was use a tsl connection instead of straight net if the secure option is passed in. I've tested this with specifying a key/cert (self-signed) and simply passing 'true' into the secure option and both seem to work.
I also added a secure.js to the example folder in case it wasn't clear what i'm talking about.
Let me know what you think,
-Marke