Added optional callbacks to connect and disconnect #44
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This commit doesn't apply cleanly (I think you need to pull to get the changed documentation format). I'm going to go manually merge it. Also, I'm going to apply the logic I pointed out in #28 (comment) (because I just think it's much more clear what's going on). |
Half-Shot
referenced
this pull request
in matrix-org/node-irc
Feb 23, 2019
….0.0 [Doppins] Upgrade dependency mocha to ^4.0.0
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Okay, this pull request is just for this feature, and not the toLowerCase() channel issue.
Some people might find this useful if they want to use callbacks instead of emitters.
connect(retryCount, callback)
disconnect(mesage, callback)
Both arguments are still optional and if the first argument is a function, it will be treated as the callback.
Oh, and I also cleaned up a bit of the code in join and part.