Respect opt.messageSplit when calculating message length #385
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@LinuxMercedes Can you add a test for this please? |
LinuxMercedes
force-pushed
the
message-split
branch
2 times, most recently
from
03b7eb4 to
6769cd6
Compare
LinuxMercedes
force-pushed
the
message-split
branch
from
6769cd6 to
ddbacc6
Compare
|
I went ahead and rebased this and re-ran the tests; I think it should all work now. |
|
@jirwin - do you have any plans of merging this? Would be really useful! |
|
Ping, any reason this isn't merged @jirwin? Would be helpful for me too! |
|
Just merged, I'll work on a new release here shortly. |
|
Thanks! |
|
This is released on node-irc 0.5.1 |
2 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
At some point this got dropped out of the calculations.