Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(irc): Handle speaking to empty targets. #315

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

fix(irc): Handle speaking to empty targets. #315

wants to merge 1 commit into from

Conversation

jirwin
Copy link
Collaborator

@jirwin jirwin commented Jan 21, 2015

Fixes #314.

ghost
ghost reviewed Jan 21, 2015
View reviewed changes
lib/irc.js
@@ -956,7 +956,19 @@ Client.prototype.notice = function(target, text) {

Client.prototype._speak = function(kind, target, text) {
var self = this;
var maxLength = this.maxLineLength - target.length;
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Fail early, IMO. We should fail as soon as we know the target is invalid.

@ghost
Copy link

ghost commented Jan 21, 2015

And a general comment: I'd like a test for this.

@Palid Palid mentioned this pull request Jan 21, 2015
Closed
@ghost ghost added the needs-feedback label Feb 8, 2015
@jirwin jirwin self-assigned this Apr 15, 2015
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@jirwin jirwin

Labels
needs-feedback
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Crashes if channel is undefined on say command
1 participant
@jirwin