Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

split out irc codes from client code. #31

Merged
merged 2 commits into from
Oct 27, 2011

Conversation

wraithan
Copy link
Contributor

@wraithan wraithan commented Oct 1, 2011

This moves the giant block of irc codes out of the client code and into its own file so that it is easier to read.

@wraithan
Copy link
Contributor Author

wraithan commented Oct 1, 2011

Included in #34

@wraithan
Copy link
Contributor Author

wraithan commented Oct 6, 2011

Following up on this. It was partially a stylistic change partially a functional change (500 lines of codes is intimidating when trying to dive into a new project's code). If there is anything I need to to do to get this merged, let me know.

@martynsmith
Copy link
Owner

Hey dude, since I've merged your documentation patch separately, this no-longer merges cleanly.

If I have time I'll resolve any conflicts manually sometime this weekend, but if you're really keen to get it rolling, it'd be great if you could fix this up into a clean merge :-)

@wraithan
Copy link
Contributor Author

I can do that tonight after work. Should only take me a minute to rebase it.

@martynsmith
Copy link
Owner

This is just me "marking" this pull request as read, I'm not sure if there's a smarter way to do it, but it'll appear back on my "need to do something" list once you've fixed up the merge :-)

@wraithan
Copy link
Contributor Author

These should apply cleanly to master now. Sorry about forgetting about this.

martynsmith added a commit that referenced this pull request Oct 27, 2011
split out irc codes from client code.
@martynsmith martynsmith merged commit 8eb6eb5 into martynsmith:master Oct 27, 2011
thejh pushed a commit to thejh/node-irc that referenced this pull request Nov 6, 2011
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants