Fix TLS connections. #304
Merged
Fix TLS connections. #304
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ghost
added
the
Root cause: the `self.opt.selfSigned` parameter wasn't being assigned to the options passed to `tls.connect()`, meaning that connections to most ircds would fail. This explains why connections to freenode (who have a proper certificate) work while connections to most other ircds (which use self-signed certs) fail. While here, write some tests that ensure connecting to a secure server actually works. This involves a refactor of tests/test-irc.js to support both plaintext and encrypted connections. This also includes a self-signed certificate for testing locally. There are also a few small, minor fixes to the helpers to either remove unnecessary code or clean up. MockIrcd now supports an option to its constructor that determines whether the connection should be secure or not. Still to do: refactor all of the TLS handling in irc.js to be cleaner and to remove the duplicate code.
jirwin
force-pushed
the
apeiron/fix-secure-connections
branch
from
8b5ba77 to
5727077
Compare
|
+1 |
This was referenced Jan 13, 2015
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Root cause: the
self.opt.selfSignedparameter wasn't beingassigned to the options passed to
tls.connect(), meaning thatconnections to most ircds would fail. This explains why
connections to freenode (who have a proper certificate) work
while connections to most other ircds (which use self-signed
certs) fail.
While here, write some tests that ensure connecting to a secure
server actually works. This involves a refactor of
tests/test-irc.js to support both plaintext and encrypted
connections. This also includes a self-signed certificate for
testing locally.
There are also a few small, minor fixes to the helpers to either
remove unnecessary code or clean up. MockIrcd now supports an
option to its constructor that determines whether the connection
should be secure or not.
Still to do: refactor all of the TLS handling in irc.js to be
cleaner and to remove the duplicate code.