Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix data split delimiter #280

Merged
2 commits merged into from
Jan 10, 2015
+3 −1
Merged

Fix data split delimiter #280

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
bce415d
fix data split delimiter
ota42y Jan 7, 2015
84c2110
use RegExp object
ota42y Jan 9, 2015
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 3 additions & 1 deletion lib/irc.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -28,6 +28,8 @@ exports.colors = colors;

var replyFor = require('./codes');

var lineDelimiter = new RegExp('\r\n|\r|\n')

function Client(server, nick, opt) {
var self = this;
self.opt = {
Expand Down Expand Up @@ -736,7 +738,7 @@ Client.prototype.connect = function(retryCount, callback) {
buffer = Buffer.concat([buffer, chunk]);
}

var lines = self.convertEncoding(buffer).toString().split('\r\n');
var lines = self.convertEncoding(buffer).toString().split(lineDelimiter);

if (lines.pop()) {
// if buffer is not ended with \r\n, there's more chunks.
Expand Down