Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use CHANMODES for modifying channel modes and lists (v0.3) #270

Closed
wants to merge 3 commits into from

Conversation

awwright
Copy link

@awwright awwright commented Jan 6, 2015

Fixes issue #144, hopefully #222, and obsoletes #145

this.setting = {};
}
exports.Channel = Channel;
Channel.prototype.key = '';
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Aren't all of these properties already being defined on the instance above in the constructor?

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm just hinting at the type that each property will be once the constructor has finished its inititialization. It might be unnecessary for most purposes, and it definitely should't make a difference during execution.

@jirwin
Copy link
Collaborator

jirwin commented Jan 7, 2015

In an effort to get the project back on track and always have master deployable, we've moved the 0.3.x branch back to master. Since Github doesn't allow you to change which branch a Pull Request was opened against, you'll need to re-open this pull request against the new master.

I've written a wikipage at https://github.com/martynsmith/node-irc/wiki/0.3.x-branch-debacle to try and help with the transition.

Thanks!

@jirwin
Copy link
Collaborator

jirwin commented Jan 7, 2015

If you'd like I can re-open this PR and pull in your commits from your fork.

@awwright
Copy link
Author

awwright commented Jan 7, 2015

Reopening #145

@awwright awwright closed this Jan 7, 2015
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants