Added support for Ping Timeouts #214
Conversation
In order to send PINGs, as far as I can tell, we must know the name of our host, so I've also added a mechanism for accepting the "yourhost" event and storing the name received, then using that for the pings. Of course, we might get a timeout after connection and waiting for the "yourhost" event, so there's a timer there as well.
|
I'm not sure as to what purpose the |
|
The 002 timer is so that if in-between connecting to the server and getting a 002 message, After the 002 message has been received, we can start sending PINGs and getting PONGs (using the normal ping timer). |
|
@martynsmith Any chance of reopening this issue? I realize it probably just got lost in the noise back during the project restructuring, but there seems to be some demand for it (see #375 ) |
ghost
mentioned this pull request
|
Can this be reopened? Thanks! |
|
@philip-peterson any chance you could try to re-merge and resolve the conflicts? |
|
I've been busy lately, but maybe someday soon... in the meantime if anyone else wants to migrate the changes, I'd encourage it. |
|
I spent hours learning git and haven't learned how to merge yet, or i would. |
|
This was fixed in #418. |
In order to send PINGs, as far as I can tell, we must know the name of our host,
so I've also added a mechanism for accepting the "yourhost" event and storing
the name received, then using that for the pings.
Of course, we might get a timeout after connection and waiting for the "yourhost"
event, so there's a timer there as well.