Fixed bug with coilon inside message string #133
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Already fixed (though not committed), please see the comments under #128. |
quentinxs
added a commit
to quentinxs/node-irc
that referenced
this pull request
Jan 19, 2013
This fixes issues martynsmith#122, martynsmith#128 and martynsmith#133. Example lines include: :some.irc.net 324 webuser #channel +Cnj 5:10 :nick!user@host QUIT :Ping timeout: 252 seconds :nick!user@host PRIVMSG #channel :so : colons: :are :: not a problem ::::
|
I'm going to close this now (pull request #137 from @qsheets fixed this issue I believe). If you still have issues, please pull master and look at the tests I've written, if you can extend the tests with your own failing examples, that will provide a much better basis for trying out new patches). Thanks, |
uiur
pushed a commit
to uiur/node-irc
that referenced
this pull request
Feb 2, 2013
This fixes issues martynsmith#122, martynsmith#128 and martynsmith#133. Example lines include: :some.irc.net 324 webuser #channel +Cnj 5:10 :nick!user@host QUIT :Ping timeout: 252 seconds :nick!user@host PRIVMSG #channel :so : colons: :are :: not a problem ::::
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
If you write e.g. "this is a message with : a colon in it" the resulting string is ":this" because it parses the last colon found, not the first.