-
Notifications
You must be signed in to change notification settings - Fork 421
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Added SASL support #125
Added SASL support #125
Conversation
Set sasl: true in options, along with nick, userName, and password, for SASL login (required for some IP ranges for connecting to Freenode, etc.).
While I applaud your effort, you may want to rework your code a bit as |
Yes, I was kind of greedy with the CAP signals since nothing else in the library is using them yet. The third commit makes it more specific. When a use case comes up for other CAP functionality it can be accommodated then. The last commit adds the option to the docs. If these additions don't hinder other uses, I would really appreciate their inclusion. I can't connect to Freenode via my phone without them (anything on the T-Mobile network is subject to SASL). |
I could also move those listeners into the |
👍 |
This looks fine, I notice that we get fairly wildly varying coding styles, I think I might get some jshint config set up and try to get everyone to conform to that :-) |
Thanks for merging this in! |
Set sasl: true in options, along with nick, userName, and password,
for SASL login (required for some IP ranges for connecting to
Freenode, etc.).
No docs or tests, sorry. Happy to provide if you give some guidance.