handle important when specified for view-transition-names

martrapp · Sep 19, 2024 · c0f574e · c0f574e
1 parent 2680391
commit c0f574e
Show file tree

Hide file tree

Showing 4 changed files with 16 additions and 8 deletions.
diff --git a/.changeset/kind-apricots-shave.md b/.changeset/kind-apricots-shave.md
@@ -0,0 +1,6 @@
+---
+'astro-vtbot': patch
+---
+
+Handles "!important" correctly when used with view-transition-names.  
+
diff --git a/components/css.ts b/components/css.ts
@@ -83,7 +83,9 @@ export function elementsWithPropertyInStylesheet(
 		definitions.set(sheet, set);
 		const text = (owner?.textContent ?? '').replace(/@supports[^;{]+/g, '');
 		const matches = text.matchAll(new RegExp(`${property}:\\s*([^;}]*)`, 'gu'));
-		[...matches].forEach((match) => set.add(decode(property, match[1]!)));
+		[...matches].forEach((match) =>
+			set.add(decode(property, match[1]!.replace(/\s*!important\s*$/, '')))
+		);
 	});
 
 	walkSheets([...doc.styleSheets], undefined, (rule) => {

diff --git a/package-lock.json b/package-lock.json
diff --git a/package.json b/package.json
@@ -86,7 +86,7 @@
     "@playwright/test": "^1.47.1",
     "@types/dom-view-transitions": "^1.0.5",
     "@types/node": "^22.5.5",
-    "astro": "^4.15.5",
+    "astro": "^4.15.8",
     "prettier": "^3.3.3",
     "prettier-plugin-astro": "^0.14.1",
     "typescript": "^5.6.2"