apply_fixes: Support cquery and custom bazel arguments #249
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
martis42
force-pushed
the
apply_fixes_support_cquery
branch
from
fcee83d
to
2a1dabe
Compare
Until now the apply_fixes script by default uses `bazel query` to find missing dependencies. A project might use select statements to exchange dependencies. In such cases one should use `bazel cquery` to allow the apply_fixes script to understand the dependency tree properly. This also requires the user being able to provide arguments to `bazel cquery`. Refactoring incorporated into this: - Due to the missing dependency discover logic increasing in complexity, we spit it into a separate module - We output commands as a single string in verbose mode to ease copying them for debugging
martis42
force-pushed
the
apply_fixes_support_cquery
branch
from
2a1dabe
to
b8d911d
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Until now the apply_fixes script by default uses
bazel queryto find missing dependencies. A project might use select statements to exchange dependencies. In such cases one should usebazel cqueryto allow the apply_fixes script to understand the dependency tree properly. This also requires the user being able to provide arguments tobazel cquery.Refactoring incorporated into this: