Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove stray "is" #247

Merged
merged 2 commits into from
May 2, 2024
Merged

Remove stray "is" #247

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
93a36e0
Remove stray "is"
May 2, 2024
b40c4cf
Merge branch 'main' into grammar
martis42 May 2, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
12 changes: 6 additions & 6 deletions src/apply_fixes/apply_fixes.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -132,8 +132,8 @@ def mach_deps_to_include(target: str, invalid_include: str, target_deps: list[De
logging.warning(
f"""
Found multiple targets providing invalid include path '{invalid_include}' of target '{target}'.
Cannot determine correct dependency.
Discovered potential dependencies are: {deps_providing_included_path}.
Cannot determine correct dependency.
Discovered potential dependencies are: {deps_providing_included_path}.
""".strip()
)
return None
Expand All @@ -153,17 +153,17 @@ def mach_deps_to_include(target: str, invalid_include: str, target_deps: list[De
logging.warning(
f"""
Found multiple targets providing file '{included_file}' from invalid include '{invalid_include}' of target '{target}'.
Matching the full include path did not work. Cannot determine correct dependency.
Discovered potential dependencies are: {deps_providing_included_file}.
Matching the full include path did not work. Cannot determine correct dependency.
Discovered potential dependencies are: {deps_providing_included_file}.
""".strip()
)
return None

logging.warning(
f"""
Could not find a proper dependency for invalid include path '{invalid_include}' of target '{target}'.
Is the header file maybe wrongly part of the 'srcs' attribute instead of 'hdrs' in the library which should provide the header?
Or is this include is resolved through the toolchain instead through a dependency?
Is the header file maybe wrongly part of the 'srcs' attribute instead of 'hdrs' in the library which should provide the header?
Or is this include resolved through the toolchain instead through a dependency?
""".strip()
)
return None
Expand Down