Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Streamline module bazel #239

Merged
merged 3 commits into from
Apr 14, 2024
Merged

Streamline module bazel #239

merged 3 commits into from
Apr 14, 2024

Commits on Apr 14, 2024

  1. Use upstream mypy_integration 

    - No longer depend on mypy fork
- Use bzlmod for fetching
    @martis42
    martis42 committed Apr 14, 2024
    Configuration menu
    Copy the full SHA
    a6f004e View commit details
    Browse the repository at this point in the history

  2. Simplify module files 

    - Drop superfluous versions which are ignored either way
- Do not specify compatibility_level where it is not required
- Do not keep root module rules_python in sync with examples. We specify
  the minimum version in the root file, whereas is the examples we can
  choose freely.
- Consistent naming
    @martis42
    martis42 committed Apr 14, 2024
    Configuration menu
    Copy the full SHA
    903d6a4 View commit details
    Browse the repository at this point in the history

  3. Prefer single line style in module files where possible 

    Looking at other project the single line style seems to be overall preferred.
This makes sense, as this way it is easier to see more relevant information
at once.
    @martis42
    martis42 committed Apr 14, 2024
    Configuration menu
    Copy the full SHA
    06175a8 View commit details
    Browse the repository at this point in the history