Introduce target mapping #153
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Having a private and empty aspect config as impl detail for signaling that no external config was provided is kinda hacky. Using a list is the more elegant workaround for the limited aspect attr API due to "empty" vs "not empty" matching closer to "nothing has been provided" and "User provided a value".
Sometimes users don't want to follow the DWYU rules for all targets or have to work with external dependencies not following the DWYU principles. For such cases DWYU allows now creating a mapping which for a chosen target makes more headers available as the target actually provides. In other words, one can combine virtually for the DWYU analysis multiple targets. Doing so allows using headers from transitive dependencies without DWYU raising an error for select cases.
martis42
force-pushed
the
introduce_target_mapping
branch
from
025b504
to
b5adb8c
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Sometimes users don't want to follow the DWYU rules for all targets or have to work with external dependencies not following the DWYU principles.
For such cases DWYU allows creating a mapping which for a chosen target makes more headers available as the target actually provides.
In other words, one can combine virtually for the DWYU analysis multiple targets.
Doing so allows using headers from transitive dependencies without DWYU raising an error for select cases.
Related to #138