Fix issue with long path names. #152
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
In deeply nested workspace and/or long target names the paths for the various DWYU artifacts can become quite long. At some point they are too large for Bazel and the OS to handle and consequently DWYU fails. We fix this by: - We use only the name of the to be analyzed target instead of its full label as prefix for the DWYU artifacts. The artifacts are generated inside bazel-out in the package location of the to be analyzed target and thus the name is sufficient as suffix to guarantee unique results. - For the DWYU artifacts depending on dependencies we no longer use the dependency label as path suffix, but instead use the hash of the label. This gives us an upper bound on the max length of the generated file names while still making name collision quite unlikely. That the names are less verbose does not matter. If one wants to debug, the name of the dependency is contained in the file either way.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In deeply nested workspace and/or long target names the paths for the various DWYU artifacts can become quite long. At some point they are too large for Bazel and the OS to handle and consequently DWYU fails.
We fix this by:
Resolves #151