Skip to content

Commit

Permalink
test: Drop Bazel windows symlinking startup option
Browse files Browse the repository at this point in the history
No performance improvement could be measured in out GitHub Actions CI setup.
Either, our windows workers have the developer mode not enabled or the use
case optimized by this flag does not apply to us.
  • Loading branch information
martis42 committed Dec 16, 2024
1 parent a8b647f commit c50f6ac
Show file tree
Hide file tree
Showing 4 changed files with 0 additions and 14 deletions.
4 changes: 0 additions & 4 deletions examples/.bazelrc
Original file line number Diff line number Diff line change
@@ -1,7 +1,3 @@
# Can improve performance in Windows workers
# See https://github.com/bazelbuild/rules_python/blob/7bba79de34b6352001cb42b801245d0de33ce225/docs/sphinx/pypi-dependencies.md#L40
startup --windows_enable_symlinks

# Do not waste memory by keeping idle Bazel servers around
startup --max_idle_secs=10

Expand Down
4 changes: 0 additions & 4 deletions test/apply_fixes/execution_logic.py
Original file line number Diff line number Diff line change
Expand Up @@ -35,10 +35,6 @@
"""

BAZEL_RC_FILE = """
# Can improve performance in Windows workers
# See https://github.com/bazelbuild/rules_python/blob/7bba79de34b6352001cb42b801245d0de33ce225/docs/sphinx/pypi-dependencies.md#L40
startup --windows_enable_symlinks
# Decrease Python toolchain overhead
# See https://github.com/bazelbuild/rules_python/issues/1653
common --nolegacy_external_runfiles
Expand Down
3 changes: 0 additions & 3 deletions test/aspect/test_case.py
Original file line number Diff line number Diff line change
Expand Up @@ -101,9 +101,6 @@ def _run_bazel_build(
"--ignore_all_rc_files",
# Do not waste memory by keeping idle Bazel servers around
"--max_idle_secs=10",
# Can improve performance in Windows workers
# See https://github.com/bazelbuild/rules_python/blob/7bba79de34b6352001cb42b801245d0de33ce225/docs/sphinx/pypi-dependencies.md#L40
"--windows_enable_symlinks",
"build",
"--experimental_convenience_symlinks=ignore",
"--noshow_progress",
Expand Down
3 changes: 0 additions & 3 deletions test/aspect/test_case_test.py
Original file line number Diff line number Diff line change
Expand Up @@ -87,7 +87,6 @@ def test_dwyu_command_without_any_extra_args(self, run_mock: MagicMock) -> None:
"--output_base=/some/path",
"--ignore_all_rc_files",
"--max_idle_secs=10",
"--windows_enable_symlinks",
"build",
"--experimental_convenience_symlinks=ignore",
"--noshow_progress",
Expand Down Expand Up @@ -119,7 +118,6 @@ def test_dwyu_command_with_global_and_dwyu_extra_args(self, run_mock: MagicMock)
"--output_base=/some/path",
"--ignore_all_rc_files",
"--max_idle_secs=10",
"--windows_enable_symlinks",
"build",
"--experimental_convenience_symlinks=ignore",
"--noshow_progress",
Expand Down Expand Up @@ -155,7 +153,6 @@ def test_dwyu_command_with_multiple_targets(self, run_mock: MagicMock) -> None:
"--output_base=/some/path",
"--ignore_all_rc_files",
"--max_idle_secs=10",
"--windows_enable_symlinks",
"build",
"--experimental_convenience_symlinks=ignore",
"--noshow_progress",
Expand Down

0 comments on commit c50f6ac

Please sign in to comment.