Skip to content

Commit

Permalink
refctor: Stop using poetry
Browse files Browse the repository at this point in the history
Using poetry merely for running pre-commit is overkill. Especially, given
the pre-commit GitHub action either way ignored our setup and
downloaded and used the latest pre-commit version.
pre-commit is an established tool with a stable behavior. All users can
be expected to install it for themselves. Furthermore, we can ensure a
fairly recent version is used via the pre-commit config.
  • Loading branch information
martis42 committed Dec 10, 2024
1 parent 4d83c93 commit 3dd4611
Show file tree
Hide file tree
Showing 5 changed files with 3 additions and 221 deletions.
11 changes: 0 additions & 11 deletions .github/workflows/ci.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -7,18 +7,7 @@ jobs:
runs-on: ubuntu-24.04
steps:
- uses: actions/checkout@v4
- uses: snok/install-poetry@v1
with:
virtualenvs-create: true
virtualenvs-in-project: true
installer-parallel: true
- uses: actions/setup-python@v5
with:
python-version: "3.10"
cache: 'poetry'
- name: Install dependencies
run: poetry install --no-interaction --no-root
- run: source .venv/bin/activate
- uses: pre-commit/[email protected]

fast-tests:
Expand Down
2 changes: 2 additions & 0 deletions .pre-commit-config.yaml
Original file line number Diff line number Diff line change
@@ -1,3 +1,5 @@
minimum_pre_commit_version: 4.0.0

define: &generated_doc_files "^docs/(cc_info_mapping|dwyu_aspect).md"

repos:
Expand Down
194 changes: 0 additions & 194 deletions poetry.lock

This file was deleted.

15 changes: 0 additions & 15 deletions pyproject.toml

This file was deleted.

2 changes: 1 addition & 1 deletion test_basic.sh
Original file line number Diff line number Diff line change
Expand Up @@ -6,7 +6,7 @@ set -o nounset
echo ""
echo "Pre-commit checks"
echo ""
poetry run pre-commit run --all-files
pre-commit run --all-files

echo ""
echo "Execute unit tests"
Expand Down

0 comments on commit 3dd4611

Please sign in to comment.