Make change ids in tests repeatable #964
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ilyagr
force-pushed
the
ig/repeatable-ids
branch
from
c792f5a
to
ec778c4
Compare
ilyagr
force-pushed
the
ig/repeatable-ids
branch
6 times, most recently
from
c97e704
to
6b45d6f
Compare
martinvonz
reviewed
Jan 2, 2023
3 tasks
yuja
reviewed
Jan 2, 2023
The timestamp couldn't be set with `--config-toml 'user.timestamp=...'`.
It makes more sense for this function to change `self`.
ilyagr
force-pushed
the
ig/repeatable-ids
branch
5 times, most recently
from
1616859
to
2571f82
Compare
yuja
reviewed
Jan 3, 2023
martinvonz
approved these changes
Jan 3, 2023
There was a problem hiding this comment.
This looks good as far as I'm concerned, so just see how @yuja feels about the remaining unresolved comments.
|
@yuja, are you OK with the current state of this? There's no rush, I'm just checking if you're waiting on me or I'm waiting on you. |
ilyagr
force-pushed
the
ig/repeatable-ids
branch
from
2571f82
to
ad9b344
Compare
Can you remove scary comment about Other than that, this PR looks good. |
Some hijinx are utilized to make it possible to generate random values using an immutable `&UserSettings` reference.
Moves all the config that depends on the command number next to each other.
In the following commit, we replace it everywhere else.
This will be needed to test functionality for showing shortest unique prefix for commit and change ids. As a bonus, this also allows us to test log output with change ids. As another bonus, this will prevent occasional CI failures like https://github.com/martinvonz/jj/actions/runs/3817554687/jobs/6493881468.
ilyagr
force-pushed
the
ig/repeatable-ids
branch
from
ad9b344
to
f20050e
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This will be needed to test functionality for showing shortest
unique prefix for commit and change ids. As a bonus, this also
allows us to test log output with change ids.
As another bonus, this will prevent occasional CI failures like
https://github.com/martinvonz/jj/actions/runs/3817554687/jobs/6493881468.
Checklist
If applicable: