fix append and join of param parts #232
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi, I think the indentation was messed up in
decode_param
. It make sense to me that value is appended tovalue_results
at the and of the innermost for loop, and thevalue_results
are joined outside the outermost loop, just before returning.This was made clear with an email with an attachment whose filename contained a newline "\n", where only the part before the newline was actually present in the resulting filename.
Thanks
Regards