Added a custom key function in server side #6
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Users can now provide a
:key-fn
to the server handler which givenfile-name
andmime-type
will determine the key to use for the S3 file.Caveat: if the client provides a file
my-file.txt
and the:key-fn
generates a random number as a key (i.e.12314345
), the file location in S3 is given by12314345
, which is what was passed back in thes3-pipe
uploaded channel. The file location is no longer sufficient for the client to know which file was successfully uploaded (in case of parallel uploads).My (non-backwards-compatible) proposal is to put in the
uploaded
channel all information relevant to the client: both the file object that was uploaded and the response from S3 which contains the:key
,:location
,:bucket
, and:etag
.